Hi David, Here are my comments:
1. Please remove " Contributed-under: TianoCore Contribution Agreement 1.0" from your commit message as it is no longer needed. 2. Please don't add this entry: WhiskeylakeURvp = WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/build_config.cfg WhiskeylakeOpenBoardPkg does not exist yet, and it will be coming from a separate patch series. 3. Please rename BoardX58ICH10 to follow Pascal casing: BoardX58Ich10 4. Please update edk2-platforms/Platform/Intel/Readme.md to add SimicsOpenBoardPkg to the Board Support list. Other than that, looks good! Please send an updated patch. Thanks, Nate -----Original Message----- From: Wei, David Y Sent: Friday, August 9, 2019 3:47 PM To: devel@edk2.groups.io Cc: Wu, Hao A <hao.a...@intel.com>; Gao, Liming <liming....@intel.com>; Sinha, Ankit <ankit.si...@intel.com>; Agyeman, Prince <prince.agye...@intel.com>; Kubacki, Michael A <michael.a.kuba...@intel.com>; Desimone, Nathaniel L <nathaniel.l.desim...@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com> Subject: [edk2-platform patch 7/7] Platform/Intel: Add build option for SIMICS QSP Platform Add build option in build script for SIMICS QSP Platform Cc: Hao Wu <hao.a...@intel.com> Cc: Liming Gao <liming....@intel.com> Cc: Ankit Sinha <ankit.si...@intel.com> Cc: Agyeman Prince <prince.agye...@intel.com> Cc: Kubacki Michael A <michael.a.kuba...@intel.com> Cc: Nate DeSimone <nathaniel.l.desim...@intel.com> Cc: Michael D Kinney <michael.d.kin...@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: David Wei <david.y....@intel.com> --- Platform/Intel/build.cfg | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Platform/Intel/build.cfg b/Platform/Intel/build.cfg index fc6e4fe824..2ebe09a632 100644 --- a/Platform/Intel/build.cfg +++ b/Platform/Intel/build.cfg @@ -54,3 +54,5 @@ NUMBER_OF_PROCESSORS = 0 KabylakeRvp3 = KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg N1xxWU = ClevoOpenBoardPkg/N1xxWU/build_config.cfg BoardMtOlympus = PurleyOpenBoardPkg/BoardMtOlympus/build_config.cfg +WhiskeylakeURvp = +WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/build_config.cfg +BoardX58ICH10 = SimicsOpenBoardPkg/BoardX58ICH10/build_config.cfg -- 2.16.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#45748): https://edk2.groups.io/g/devel/message/45748 Mute This Topic: https://groups.io/mt/32816101/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
