> -----Original Message----- > From: Gao, Liming > Sent: Thursday, August 15, 2019 4:31 PM > To: Wu, Hao A; Zhang, Shenglei; devel@edk2.groups.io > Cc: Bi, Dandan > Subject: RE: [PATCH v2 1/1] MdeModulePkg/DxeIplPeim: Initialize pointer > PageMapLevel5Entry > > That's fine. Thanks! > > >-----Original Message----- > >From: Wu, Hao A > >Sent: Thursday, August 15, 2019 3:23 PM > >To: Gao, Liming <liming....@intel.com>; Zhang, Shenglei > ><shenglei.zh...@intel.com>; devel@edk2.groups.io > >Cc: Bi, Dandan <dandan...@intel.com> > >Subject: RE: [PATCH v2 1/1] MdeModulePkg/DxeIplPeim: Initialize pointer > >PageMapLevel5Entry > > > >> -----Original Message----- > >> From: Gao, Liming > >> Sent: Thursday, August 15, 2019 10:27 AM > >> To: Zhang, Shenglei; devel@edk2.groups.io > >> Cc: Bi, Dandan; Wu, Hao A > >> Subject: RE: [PATCH v2 1/1] MdeModulePkg/DxeIplPeim: Initialize pointer > >> PageMapLevel5Entry > >> > >> Shenglei: > >> > >> > -----Original Message----- > >> > From: Zhang, Shenglei > >> > Sent: Thursday, August 15, 2019 10:23 AM > >> > To: devel@edk2.groups.io > >> > Cc: Bi, Dandan <dandan...@intel.com>; Gao, Liming > >> <liming....@intel.com>; Wu, Hao A <hao.a...@intel.com> > >> > Subject: [PATCH v2 1/1] MdeModulePkg/DxeIplPeim: Initialize pointer > >> PageMapLevel5Entry > >> > > >> > Initialize PageMapLevel5Entry at the beginning of the function. > >> > > >> > This commit will fix a GCC 4.8.5 build failure introduced by commit > >> > b3527dedc3951f061c5a73cb4fb2b0f95f47e08b. > >> > > >> > OvmfPkg build failure wtih gcc 4.8.5 still exists at latest edk2 version. > >> > The commit 46f8a6891606746ca8b1e684ac379ce271306dc0 seems not to > fix > >> > the build failure completely. > >> > > >> > Cc: Dandan Bi <dandan...@intel.com> > >> > Cc: Liming Gao <liming....@intel.com> > >> > Cc: Hao A Wu <hao.a...@intel.com> > >> > Signed-off-by: Shenglei Zhang <shenglei.zh...@intel.com> > >> > --- > >> > v2: Add comments to state why set initialize to NULL. > >> > > >> > MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c | 5 +++++ > >> > 1 file changed, 5 insertions(+) > >> > > >> > diff --git a/MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c > >> b/MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c > >> > index 2389f3eb485b..2f1038b1e67e 100644 > >> > --- a/MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c > >> > +++ b/MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c > >> > @@ -652,6 +652,11 @@ CreateIdentityMappingPageTables ( > >> > UINT64 AddressEncMask; > >> > IA32_CR4 Cr4; > >> > > >> > + // > >> > + // set PageMapLevel5Entry to suppress incorrect compiler/analyzer > >> warnigns > >> > >> Please fix the typo warnigns ==> warnings > > > > > >Hello Liming, > > > >I will fix the above typo when I push the patch. > >Also, I will keep your RB tag from V1 patch since there is only comment > >change between the two versions.
Reviewed-by: Hao A Wu <hao.a...@intel.com> With the above typo fixed, pushed via commit 0680d08683. Best Regards, Hao Wu > > > >Best Regards, > >Hao Wu > > > > > >> > >> Thanks > >> Liming > >> > + // > >> > + PageMapLevel5Entry = NULL; > >> > + > >> > // > >> > // Make sure AddressEncMask is contained to smallest supported > >address > >> field > >> > // > >> > -- > >> > 2.18.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#45753): https://edk2.groups.io/g/devel/message/45753 Mute This Topic: https://groups.io/mt/32882542/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
