Hi All, This is patch to fix build failure. I'd like the patch to be checked in before this stable tag.
Thanks, Shenglei > -----Original Message----- > From: Gao, Zhichao > Sent: Friday, August 16, 2019 2:19 PM > To: Zhang, Shenglei <shenglei.zh...@intel.com>; devel@edk2.groups.io > Cc: Carsey, Jaben <jaben.car...@intel.com>; Ni, Ray <ray...@intel.com> > Subject: RE: [PATCH v2 1/1] ShellPkg/UefiShellAcpiViewCommandLib: > Replace shift logical left > > Reviewed-by: Zhichao Gao <zhichao....@intel.com> > > Thanks, > Zhichao > > > -----Original Message----- > > From: Zhang, Shenglei > > Sent: Friday, August 16, 2019 2:11 PM > > To: devel@edk2.groups.io > > Cc: Carsey, Jaben <jaben.car...@intel.com>; Ni, Ray <ray...@intel.com>; > > Gao, Zhichao <zhichao....@intel.com> > > Subject: [PATCH v2 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Replace > > shift logical left > > > > Replace the operation to shift logical left with the function LShiftU64, > > which > > has the same functionality. > > The original code causes ShellPkg build failure with build target"-b NOOPT". > > > > Cc: Jaben Carsey <jaben.car...@intel.com> > > Cc: Ray Ni <ray...@intel.com> > > Cc: Zhichao Gao <zhichao....@intel.com> > > Signed-off-by: Shenglei Zhang <shenglei.zh...@intel.com> > > --- > > v2: There is no return target from LShiftU64 in v1 patch. > > So update code to "Val = LShiftU64(Val,32)". > > > > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c > > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c > > index 94bafa22ef4c..a569c3c55406 100644 > > --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c > > +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c > > @@ -294,7 +294,7 @@ DumpUint64 ( > > > > Val = *(UINT32*)(Ptr + sizeof (UINT32)); > > > > - Val <<= 32; > > + Val = LShiftU64(Val,32); > > Val |= (UINT64)*(UINT32*)Ptr; > > > > Print (Format, Val); > > -- > > 2.18.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#45802): https://edk2.groups.io/g/devel/message/45802 Mute This Topic: https://groups.io/mt/32895687/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
