Reviewed-by: Chasel Chiu <[email protected]>
> -----Original Message----- > From: Cheng, Ching JenX > Sent: Monday, August 19, 2019 5:24 PM > To: [email protected] > Cc: Chan, Amy <[email protected]>; Kubacki, Michael A > <[email protected]>; Chiu, Chasel <[email protected]>; > Desimone, Nathaniel L <[email protected]>; Gao, Liming > <[email protected]> > Subject: [edk2-platforms: PATCH v2] Python run fail if env variable > PYTHON_HOME is not set > > BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2041 > > [PATCH v2] Update related files > > In Platform\Intel\MinPlatformPkg\Tools\Fsp\RebaseFspBinBaseAddress.py > It will run another python code. > But if the environment variable "PYTHON_HOME" is not exist and we didn't > add any python's path to "PATH". > It will cause error because python command not found. > > the error message as below: > 'python' is not recognized as an internal or external command, operable > program or batch file. > > So we set the python's path from which execute the python code if > PYTHON_HOME was not exist. > > Cc: Amy Chan <[email protected]> > Cc: Michael Kubacki <[email protected]> > Cc: Chasel Chiu <[email protected]> > Cc: Nate DeSimone <[email protected]> > Cc: Liming Gao <[email protected]> > Signed-off-by: Ching JenX Cheng <[email protected]> > --- > Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseFspBinBaseAddress.py | 2 > ++ > 1 file changed, 2 insertions(+) > > diff --git > a/Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseFspBinBaseAddress.py > b/Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseFspBinBaseAddress.py > index a8165b08e6..fb4cf4f9b7 100644 > --- a/Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseFspBinBaseAddress.py > +++ > b/Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseFspBinBaseAddress.py > @@ -68,6 +68,8 @@ file.close() > pythontool = 'python' > if 'PYTHON_HOME' in os.environ: > pythontool = os.environ['PYTHON_HOME'] + os.sep + 'python' > +else: > + pythontool = sys.executable > Process = subprocess.Popen([pythontool, splitFspBinPath, > "info","-f",fspBinFilePath], stdout=subprocess.PIPE) Output = > Process.communicate()[0] FsptInfo = Output.rsplit(b"FSP_M", 1); > -- > 2.21.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#46040): https://edk2.groups.io/g/devel/message/46040 Mute This Topic: https://groups.io/mt/32942124/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
