Hi Jordan, Thank you for the reviews. I have addressed the two issues you raised in my local branch and I verified that the lldbefi.py script behaves the same after breaking up the long line.
Best regards, Mike > -----Original Message----- > From: Justen, Jordan L > Sent: Sunday, August 18, 2019 7:43 PM > To: Kinney, Michael D <michael.d.kin...@intel.com>; > devel@edk2.groups.io > Cc: Andrew Fish <af...@apple.com>; Ni, Ray > <ray...@intel.com> > Subject: Re: [Patch V5 00/11] EmulatorPkg: Fix VS20xx > IA32 boot and simplify build config > > On 2019-08-16 17:57:04, Michael D Kinney wrote: > > > > Andrew Fish (7): > > EmulatorPkg/Unix/Host: Disable inline/optimizations > > Maybe add XCODE5 in commit message subject? > > Acked-by: Jordan Justen <jordan.l.jus...@intel.com> > > > EmulatorPkg: Fix XCODE5 lldb issues > > There was another long line in the > EmulatorPkg/Unix/lldbefi.py change. > > Acked-by: Jordan Justen <jordan.l.jus...@intel.com> > > > EmulatorPkg/Unix/Host: Initialize field in > BerkeleyPacketFilter.c > > Reviewed-by: Jordan Justen <jordan.l.jus...@intel.com> > > > EmulatorPkg/Unix/Host: Remove debug code from > BerkeleyPacketFilter.c > > Reviewed-by: Jordan Justen <jordan.l.jus...@intel.com> > > > EmulatorPkg: Disable TftpDynamicCommand and LogoDxe > for XCODE5 > > Acked-by: Jordan Justen <jordan.l.jus...@intel.com> > > > EmulatorPkg/Sec: Change scope of PpiArray[10] > > Reviewed-by: Jordan Justen <jordan.l.jus...@intel.com> > > > BaseTools/tools_def.template: Add -gdwarf to XCODE5 > X64 > > Acked-by: Jordan Justen <jordan.l.jus...@intel.com> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#46044): https://edk2.groups.io/g/devel/message/46044 Mute This Topic: https://groups.io/mt/32918474/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
