Reviewed-by: Chasel Chiu <chasel.c...@intel.com>
> -----Original Message----- > From: Kubacki, Michael A > Sent: Friday, August 23, 2019 2:17 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel <chasel.c...@intel.com>; Desimone, Nathaniel L > <nathaniel.l.desim...@intel.com>; Gao, Liming <liming....@intel.com> > Subject: [edk2-platforms][PATCH V2 1/2] KabylakeOpenBoardPkg: Fix GCC > Build Failures > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2109 > > Fixes build failures on GCC7.3.0. Tested on Ubunutu 18.04.1 LTS. > > Cc: Chasel Chiu <chasel.c...@intel.com> > Cc: Nate DeSimone <nathaniel.l.desim...@intel.com> > Cc: Liming Gao <liming....@intel.com> > Signed-off-by: Michael Kubacki <michael.a.kuba...@intel.com> > --- > > Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapper > PlatformSecLib/FspWrapperPlatformSecLib.c | 2 +- > > Platform/Intel/KabylakeOpenBoardPkg/Library/BaseGpioExpanderLib/BaseG > pioExpanderLib.c | 8 +++----- > 2 files changed, 4 insertions(+), 6 deletions(-) > > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapp > erPlatformSecLib/FspWrapperPlatformSecLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapp > erPlatformSecLib/FspWrapperPlatformSecLib.c > index d73fc77f69..d40eecae95 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapp > erPlatformSecLib/FspWrapperPlatformSecLib.c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapp > erPlatformSecLib/FspWrapperPlatformSecLib.c > @@ -174,7 +174,7 @@ SecPlatformMain ( > // > CopyMem (CopyDestinationPointer, mPeiCoreFvLocationPpiList, sizeof > (mPeiCoreFvLocationPpiList)); > TopOfTemporaryRamPpiIndex = 1; > - (UINT8 *) CopyDestinationPointer += sizeof(mPeiCoreFvLocationPpiList); > + CopyDestinationPointer += sizeof (mPeiCoreFvLocationPpiList); > } > CopyMem (CopyDestinationPointer, mPeiSecPlatformPpi, > sizeof(mPeiSecPlatformPpi)); > // > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/Library/BaseGpioExpanderLib/Bas > eGpioExpanderLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/Library/BaseGpioExpanderLib/Bas > eGpioExpanderLib.c > index ead1e6df19..3d1856d89e 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/Library/BaseGpioExpanderLib/Bas > eGpioExpanderLib.c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/Library/BaseGpioExpanderLib/Bas > eGpioExpanderLib.c > @@ -1,7 +1,7 @@ > /** @file > Support for IO expander TCA6424. > > -Copyright (c) 2017, Intel Corporation. All rights reserved.<BR> > +Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR> > SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > @@ -70,12 +70,11 @@ GpioExpGetRegister ( > IN UINT8 Register > ) > { > - EFI_STATUS Status; > UINT8 WriBuf[1]; > UINT8 ReBuf[1] = {0}; > > WriBuf[0] = Register; > - Status = I2cWriteRead( Bar0, TCA6424_I2C_ADDRESS+Address, 1, WriBuf, 1, > ReBuf, WAIT_1_SECOND); > + I2cWriteRead (Bar0, TCA6424_I2C_ADDRESS + Address, 1, WriBuf, 1, ReBuf, > WAIT_1_SECOND); > > return ReBuf[0]; > } > @@ -99,13 +98,12 @@ GpioExpSetRegister ( > IN UINT8 Value > ) > { > - EFI_STATUS Status; > UINT8 WriBuf[2]; > > WriBuf[0] = Register; > WriBuf[1] = Value; > - Status = I2cWriteRead( Bar0, TCA6424_I2C_ADDRESS+Address, 2, WriBuf, 0, > NULL, WAIT_1_SECOND); > > + I2cWriteRead (Bar0, TCA6424_I2C_ADDRESS + Address, 2, WriBuf, 0, NULL, > WAIT_1_SECOND); > } > /** > Set the input register to a give value mentioned in the function. > -- > 2.16.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#46258): https://edk2.groups.io/g/devel/message/46258 Mute This Topic: https://groups.io/mt/32992769/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
