Liming, Stephano and all stewards, My understanding is the requirement of embedding patch into the mail body is due to a limitation in old system (01.org). That system couldn't support mail attachments.
With the existence of mail attachments capability in new groups.io system, can we accept such kind of patch submission? Or any side effect you see if allowing mail attachments? Thanks, Ray From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Liming Gao Sent: Wednesday, August 28, 2019 12:59 AM To: jayanth.raghu...@dell.com; devel@edk2.groups.io Cc: wei.g....@dell.com Subject: Re: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling. OK. So, you can't use git send-email to send this patch. Another way is to fork edk2 and create the branch to include this change. Then, send the mail to let people review this patch in your branch. And, for this patch, can you submit BZ https://bugzilla.tianocore.org/ first? Then, update its commit message format based on this wiki. https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format Thanks Liming From: jayanth.raghu...@dell.com<mailto:jayanth.raghu...@dell.com> [mailto:jayanth.raghu...@dell.com] Sent: Wednesday, August 28, 2019 2:30 AM To: Gao, Liming <liming....@intel.com<mailto:liming....@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> Cc: wei.g....@dell.com<mailto:wei.g....@dell.com> Subject: RE: [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling. Hi Liming, I sent the review request based on the description in the links that you mentioned below. I sent it in an Dell Email since I cannot use GIT SMTP to send email out from our servers. Please let me know what is wrong and I can help rectify that. Regards Jayanth Raghuram DellEMC | Server Platform BIOS office + 1 512 723 1470 From: Gao, Liming <liming....@intel.com<mailto:liming....@intel.com>> Sent: Monday, August 26, 2019 8:57 PM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Raghuram, Jayanth Cc: Liu, Wei G Subject: RE: [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling. [EXTERNAL EMAIL] Can you follow this process to send this patch again? https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process And, the commit message format is https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format Thanks Liming From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> [mailto:devel@edk2.groups.io] On Behalf Of jayanth.raghu...@dell.com<mailto:jayanth.raghu...@dell.com> Sent: Tuesday, August 27, 2019 3:55 AM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> Cc: wei.g....@dell.com<mailto:wei.g....@dell.com> Subject: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling. Subject: [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling. Added checks for return parameters of LocateHandleBuffer & GetSupportedTypes function calls in InternalHstiFindAip to improve error handling. An issue was observed on Dell Poweredge R740, where the Dell PERC H740P controller UEFI driver returned InfoTypesBuffer = NULL, InfoTypesBufferCount = 0 and caused an FreePool assert. Signed-off-by: Jayanth Raghuram <jayanth.raghu...@dell.com<mailto:jayanth.raghu...@dell.com>> Cc: Wei G Liu <wei_g_...@dell.com<mailto:wei_g_...@dell.com>> Attached: 0001-MdePkg-DxeHstiLib-Added-checks-to-improve-error-hand.patch Regards Jayanth Raghuram DellEMC | Server Platform BIOS office + 1 512 723 1470 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#46549): https://edk2.groups.io/g/devel/message/46549 Mute This Topic: https://groups.io/mt/33041050/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
