> -----Original Message----- > From: Wu, Hao A > Sent: Wednesday, September 04, 2019 11:39 AM > To: [email protected]; Tyler Erickson > Cc: Wu, Hao A; Ni, Ray > Subject: [PATCH v1 1/1] MdeModulePkg/NvmExpressDxe: Allow other NSIDs > for Admin commands > > Repost the mail to the list. > > Best Regards, > Hao Wu > > -----Original Message----- > From: Tyler Erickson [mailto:[email protected]] > Sent: Tuesday, September 03, 2019 9:55 PM > To: [email protected] > Cc: Wu, Hao A; Ni, Ray > Subject: [PATCH v1 1/1] MdeModulePkg/NvmExpressDxe: Allow other NSIDs > for Admin commands > > Cc: Hao A Wu <[email protected]> > Cc: Ray Ni <[email protected]> > Signed-off-by: Tyler Erickson <[email protected]> > --- > MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressPassthru.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressPassthru.c > b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressPassthru.c > index 8e721379466a..78a3c663ded4 100644 > --- a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressPassthru.c > +++ b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressPassthru.c > @@ -561,7 +561,7 @@ NvmExpressPassThru ( > Sq = Private->SqBuffer[QueueId] + Private->SqTdbl[QueueId].Sqt; > Cq = Private->CqBuffer[QueueId] + Private->CqHdbl[QueueId].Cqh; > > - if (Packet->NvmeCmd->Nsid != NamespaceId) { > + if (Packet->QueueType != NVME_ADMIN_QUEUE && Packet->NvmeCmd- > >Nsid != NamespaceId) {
Hello, Per my understanding to the codes, I think the: * Input parameter 'NamespaceId' for the PassThru() service * The 'Nsid' field of the EFI_NVM_EXPRESS_COMMAND are of the same meaning. Do you think setting these 2 values identical when calling the PassThru() service can resolve the issue you met? Best Regards, Hao Wu > return EFI_INVALID_PARAMETER; > } > > -- > 2.17.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#46739): https://edk2.groups.io/g/devel/message/46739 Mute This Topic: https://groups.io/mt/33134758/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
