just a meta comment:
On 09/05/19 08:23, Dandan Bi wrote:
>> -----Original Message-----
>> From: Wu, Hao A
>> Sent: Thursday, September 5, 2019 1:38 PM
>> To: Bi, Dandan <[email protected]>; [email protected]
>> Cc: Wang, Jian J <[email protected]>; Ni, Ray <[email protected]>; Gao,
>> Liming <[email protected]>; Laszlo Ersek <[email protected]>
>> Subject: RE: [patch 2/3] MdeModulePkg: Unload image on
>> EFI_SECURITY_VIOLATION
>>
>>> -----Original Message-----
>>> From: Bi, Dandan
>>> Sent: Wednesday, September 04, 2019 4:26 PM
>>> To: [email protected]
>>> Cc: Wang, Jian J; Wu, Hao A; Ni, Ray; Gao, Liming; Laszlo Ersek
>>> Subject: [patch 2/3] MdeModulePkg: Unload image on
>>> EFI_SECURITY_VIOLATION
>>> MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c | 9
>>> +++++++++
>>> MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c | 9
>>> +++++++++
>>> MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 9
>> +++++++++
>>> .../Library/UefiBootManagerLib/BmLoadOption.c | 11 ++++++++++-
>>> MdeModulePkg/Library/UefiBootManagerLib/BmMisc.c | 11
>>> ++++++++++-
>>> .../PlatformDriOverrideDxe/PlatDriOverrideLib.c | 11 ++++++++++-
>> Also, since the patch is touching multiple features (PCI, Capsule, BM and
>> driver override), I would suggest to break this patch into multiple ones so
>> that it will be more clear to evaluate the impact for each change.
>>
> I will separate the patch into module level and send the new patch series.
Yes, do that please, especially because now we have fine-grained
maintainership assignments in "Maintainers.txt" (not for all packages,
but certainly for MdeModulePkg), and a python script to assign reviewers.
Let's say, you have three patches in the series, on your topic branch.
You can do:
$ python BaseTools/Scripts/GetMaintainer.py HEAD~2
$ python BaseTools/Scripts/GetMaintainer.py HEAD~1
$ python BaseTools/Scripts/GetMaintainer.py HEAD
Each invocation will give you the list of people that you should CC on
that particular patch.
You can also invoke the script with the "-l" option, to get reviewers
for a specific file:
$ python BaseTools/Scripts/GetMaintainer.py \
-l MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c
$ python BaseTools/Scripts/GetMaintainer.py \
-l MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c
Other than this, I'll skip the review of patches #2 and #3 in this
series; I've got too many things to do, and I'm not a designated
reviewer / maintainer on either module being modified. I hope that's
acceptable.
Thanks,
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#46937): https://edk2.groups.io/g/devel/message/46937
Mute This Topic: https://groups.io/mt/33136046/21656
Group Owner: [email protected]
Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
