Reviewed-by: Bob Feng <[email protected]> -----Original Message----- From: Fan, ZhijuX Sent: Friday, September 6, 2019 11:30 AM To: [email protected] Cc: Gao, Liming <[email protected]>; Feng, Bob C <[email protected]> Subject: [PATCH] BaseTools:Ecc handle another copyright format
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2057 Ecc can not handle the copyright format like (C) Copyright 2015-2016 Hewlett Packard Enterprise Development LP<BR> This will cause Ecc to report wrong information. This patch is going to handle this format Cc: Liming Gao <[email protected]> Cc: Bob Feng <[email protected]> Signed-off-by: Zhiju.Fan <[email protected]> --- BaseTools/Source/Python/Ecc/c.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Source/Python/Ecc/c.py b/BaseTools/Source/Python/Ecc/c.py index a99b40a701..a30122a45f 100644 --- a/BaseTools/Source/Python/Ecc/c.py +++ b/BaseTools/Source/Python/Ecc/c.py @@ -2388,7 +2388,7 @@ def CheckFileHeaderDoxygenComments(FullFileName): PrintErrorMsg(ERROR_HEADER_CHECK_FILE, 'File header comment content should start with two spaces at each line', FileTable, ID) CommentLine = CommentLine.strip() - if CommentLine.startswith('Copyright'): + if CommentLine.startswith('Copyright') or ('Copyright' in CommentLine and CommentLine.lower().startswith('(c)')): NoCopyrightFlag = False if CommentLine.find('All rights reserved') == -1: for Copyright in EccGlobalData.gConfig.Copyright: -- 2.14.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47018): https://edk2.groups.io/g/devel/message/47018 Mute This Topic: https://groups.io/mt/33161998/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
