Reviewed-by: Michael Kubacki <[email protected]> > -----Original Message----- > From: Chiu, Chasel > Sent: Friday, September 6, 2019 12:01 AM > To: [email protected] > Cc: Kubacki, Michael A <[email protected]>; Desimone, Nathaniel > L <[email protected]>; Gao, Liming <[email protected]> > Subject: [edk2-platforms: PATCH] KabylakeOpenBoardPkg: Missed 64KB > Temporary RAM in Dispatch mode. > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2159 > > FSP Dispatch mode will share same stack and heap with bootloader so we > should not reserve separate temporary ram for FSP. > Set PcdFspTemporaryRamSize to 0 in Dispatch mode. > > Test: internal platform can boot with FSP Dispatch mode > with 64KB temporary RAM back. > > Cc: Michael Kubacki <[email protected]> > Cc: Nate DeSimone <[email protected]> > Cc: Liming Gao <[email protected]> > Signed-off-by: Chasel Chiu <[email protected]> > --- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.ds > c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd. > dsc > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd. > dsc > index 55ae9f47ac..2009bb225a 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd. > dsc > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd. > d > +++ sc > @@ -69,10 +69,10 @@ > gSiPkgTokenSpaceGuid.PcdPeiTemporaryRamStackSize|0x20000 > !else > # > - # FSP Dispatch mode will share the same stack with boot loader, > - # here temporary ram size is used by FSP heap and can be smaller > + # FSP Dispatch mode will share the same stack and heap with boot > + loader, # no separate temporary ram required by FSP. > # > - gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize | 0x00010000 > + gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize | 0 > > # > # In FSP Dispatch mode boot loader stack size must be big enough for > executing > -- > 2.13.3.windows.1
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47092): https://edk2.groups.io/g/devel/message/47092 Mute This Topic: https://groups.io/mt/33163786/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
