On 09/24/19 12:41, Philippe Mathieu-Daudé wrote: > Hi Liming, > > On 9/24/19 3:19 AM, Liming Gao wrote: >> ShellBinPkg is generated for each edk2 stable tag release. >> >> Cc: Andrew Fish <af...@apple.com> >> Cc: Laszlo Ersek <ler...@redhat.com> >> Cc: Leif Lindholm <leif.lindh...@linaro.org> >> Cc: Michael D Kinney <michael.d.kin...@intel.com> >> Signed-off-by: Liming Gao <liming....@intel.com> >> --- >> Maintainers.txt | 13 ++++++------- >> 1 file changed, 6 insertions(+), 7 deletions(-) >> >> diff --git a/Maintainers.txt b/Maintainers.txt >> index f348d70df3..f75b35d5a8 100644 >> --- a/Maintainers.txt >> +++ b/Maintainers.txt >> @@ -82,6 +82,12 @@ EDK II Releases: >> W: >> https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning >> M: Liming Gao <liming....@intel.com> >> > > Shouldn't you keep the F: tag too? Maybe: > > ShellPkg > (stable) > F: ShellPkg/
I think we should keep "F:" only if the related "M:" entries work as expected, with the "BaseTools/Scripts/GetMaintainer.py" script. (I haven't checked.) Thanks Laszlo > > >> +W: >> https://github.com/tianocore/edk2/releases/download/edk2-stable20XXXX/ShellBinPkg.zip >> +M: Ray Ni <ray...@intel.com> (Ia32/X64) >> +M: Zhichao Gao <zhichao....@intel.com> (Ia32/X64) >> +M: Leif Lindholm <leif.lindh...@linaro.org> (ARM/AArch64) >> +M: Ard Biesheuvel <ard.biesheu...@linaro.org> (ARM/AArch64) >> + >> EDK II Architectures: >> --------------------- >> ARM, AARCH64 >> @@ -421,13 +427,6 @@ W: >> https://github.com/tianocore/tianocore.github.io/wiki/ShellPkg >> M: Ray Ni <ray...@intel.com> >> M: Zhichao Gao <zhichao....@intel.com> >> >> -Maintainers for stable Shell binaries generation >> -when need to publish Shell binaries with edk2 release: >> -M: Ray Ni <ray...@intel.com> (Ia32/X64) >> -M: Zhichao Gao <zhichao....@intel.com> (Ia32/X64) >> -M: Leif Lindholm <leif.lindh...@linaro.org> (ARM/AArch64) >> -M: Ard Biesheuvel <ard.biesheu...@linaro.org> (ARM/AArch64) >> - >> SignedCapsulePkg >> F: SignedCapsulePkg/ >> W: https://github.com/tianocore/tianocore.github.io/wiki/SignedCapsulePkg >> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47968): https://edk2.groups.io/g/devel/message/47968 Mute This Topic: https://groups.io/mt/34271643/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
