On Thu, Oct 03, 2019 at 12:52:57AM +0000, Abner Chang wrote: > > > So is the plan to just copy IoLibArm.c to IoLibRiskV.c? I kind of > > > agree with Leif that having two copies of the same thing does not make > > > sense. I do see your point about naming, but maybe the issue the > > > IoLibArm.c name. I don't see anything ARM specific in IoLibArm.c it > > > seems to me it is generic C code for a platform that does not have IO > > > Ports. So I guess we could just change the file name of IoLibArm.c to > > > IoLibNoIo.c and have ARM and RISC-V point at the common file? > > Yes, naming is my concern. No technical issues here. > Thanks for this suggestion. > > > Works for me. > > We can untangle the remaining mess unrelated from the Risc-V upstreaming. > > Leif, I will rename IoLibRiscV.c to IoLibNoIo.c in the next version > of patches. You can adopt the new file in ARM side later.
The suggestion was to rename IoLibArm.c. If you're insisting on keeping your duplicated version, you're back to looking for another maintainer to convince that this is the better solution. Best Regards, Leif -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#48423): https://edk2.groups.io/g/devel/message/48423 Mute This Topic: https://groups.io/mt/34258203/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
