Reviewed-by: Michael D Kinney <michael.d.kin...@intel.com> > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On > Behalf Of Liming Gao > Sent: Monday, October 14, 2019 5:27 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [Patch v2 05/11] MdePkg > BaseIoLibIntrinsic: Remove __inline__ attribute for IO > functions > > __inline__ has no functional difference effect with the > GCC48 / GCC49 / GCC5 toolchains, but it breaks the > build with CLANG9. Remove __inline__. > > Signed-off-by: Liming Gao <liming....@intel.com> > Acked-by: Laszlo Ersek <ler...@redhat.com> > --- > MdePkg/Library/BaseIoLibIntrinsic/IoLibGcc.c | 6 ----- > - > 1 file changed, 6 deletions(-) > > diff --git > a/MdePkg/Library/BaseIoLibIntrinsic/IoLibGcc.c > b/MdePkg/Library/BaseIoLibIntrinsic/IoLibGcc.c > index 055f0a947e..b3a1a20256 100644 > --- a/MdePkg/Library/BaseIoLibIntrinsic/IoLibGcc.c > +++ b/MdePkg/Library/BaseIoLibIntrinsic/IoLibGcc.c > @@ -32,7 +32,6 @@ > @return The value read. > > **/ > -__inline__ > UINT8 > EFIAPI > IoRead8 ( > @@ -60,7 +59,6 @@ IoRead8 ( > @return The value written the I/O port. > > **/ > -__inline__ > UINT8 > EFIAPI > IoWrite8 ( > @@ -87,7 +85,6 @@ IoWrite8 ( > @return The value read. > > **/ > -__inline__ > UINT16 > EFIAPI > IoRead16 ( > @@ -117,7 +114,6 @@ IoRead16 ( > @return The value written the I/O port. > > **/ > -__inline__ > UINT16 > EFIAPI > IoWrite16 ( > @@ -145,7 +141,6 @@ IoWrite16 ( > @return The value read. > > **/ > -__inline__ > UINT32 > EFIAPI > IoRead32 ( > @@ -175,7 +170,6 @@ IoRead32 ( > @return The value written the I/O port. > > **/ > -__inline__ > UINT32 > EFIAPI > IoWrite32 ( > -- > 2.13.0.windows.1 > > >
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#49321): https://edk2.groups.io/g/devel/message/49321 Mute This Topic: https://groups.io/mt/34540587/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
