On 10/22/19 21:06, Michael D Kinney wrote: > From: Sean Brogan <sean.bro...@microsoft.com> > > https://bugzilla.tianocore.org/show_bug.cgi?id=2255 > > Update UefiCpuPkg.dsc to guarantee all libraries and > modules are always built. Add the following components. > > * UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf > * UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.inf > > ResetVector.inf is a binary INF, so no source builds are > triggered from adding this line. However, a build with > this component does verify the contents of the INF file. > > Cc: Eric Dong <eric.d...@intel.com> > Cc: Ray Ni <ray...@intel.com> > Cc: Laszlo Ersek <ler...@redhat.com> > Signed-off-by: Michael D Kinney <michael.d.kin...@intel.com> > --- > UefiCpuPkg/UefiCpuPkg.dsc | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/UefiCpuPkg/UefiCpuPkg.dsc b/UefiCpuPkg/UefiCpuPkg.dsc > index e7dfe30eda..d28cb5cccb 100644 > --- a/UefiCpuPkg/UefiCpuPkg.dsc > +++ b/UefiCpuPkg/UefiCpuPkg.dsc > @@ -121,6 +121,7 @@ [Components.IA32, Components.X64] > UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf > UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf > UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.inf > + UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.inf > UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeCpuExceptionHandlerLib.inf > UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuExceptionHandlerLib.inf > UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmCpuExceptionHandlerLib.inf > @@ -146,6 +147,7 @@ [Components.IA32, Components.X64] > > SmmCpuFeaturesLib|UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLibStm.inf > } > UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume2Pei.inf > + UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf > > [BuildOptions] > *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES >
Can we retire UefiCpuPkg/ResetVector/Vtf0/Bin/ instead (in a separate patch)? Because, according to git log --stat master -- UefiCpuPkg/ResetVector/Vtf0/Bin/ the most recent commit in which we updated the *.raw files has been f7bb98019a71 ("UefiCpuPkg VTF0: Fix support for finding SEC image of type TE.", 2011-09-28). I doubt anyone consumes this (binary) module, since Jordan's commits - 5a1f324d946c ("UefiCpuPkg: Support building VTF0 ResetVector during the EDK II build", 2014-08-18) - eee1d2ca9078 ("UefiCpuPkg VTF0 X64: Build page tables in NASM code", 2014-08-18). We've by now dropped all top-level *BinPkg package directories too. If we remove the Bin subdir, then we should probably remove: - Build.py - Tools/ too. For the other addition (CpuCommonFeaturesLib): if that gets its own patch (after the removal of UefiCpuPkg/ResetVector/Vtf0/Bin/), then please add Reviewed-by: Laszlo Ersek <ler...@redhat.com> to it. Thanks Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#49369): https://edk2.groups.io/g/devel/message/49369 Mute This Topic: https://groups.io/mt/36448030/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-