Reviewed-by: Chasel Chiu <[email protected]>
> -----Original Message----- > From: Kubacki, Michael A <[email protected]> > Sent: Wednesday, October 30, 2019 7:05 AM > To: [email protected] > Cc: Chiu, Chasel <[email protected]>; Desimone, Nathaniel L > <[email protected]>; Jeremy Soller <[email protected]> > Subject: [edk2-platforms][PATCH V1 1/2] KabylakeOpenBoardPkg: Correct > Platform Hook Library references > > Many file descriptions reference "Platform Hook Library" when the file is not > related to the PlatformHookLib library class. This change updates those > references in KabylakeOpenBoardPkg to a more accurate description. > > Cc: Chasel Chiu <[email protected]> > Cc: Nate DeSimone <[email protected]> > Cc: Jeremy Soller <[email protected]> > Signed-off-by: Michael Kubacki <[email protected]> > --- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/ > DxeBoardAcpiTableLib.inf | 2 +- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/ > DxeMultiBoardAcpiSupportLib.inf | 2 +- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/S > mmBoardAcpiEnableLib.inf | 2 +- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/S > mmMultiBoardAcpiSupportLib.inf | 2 +- > > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/Sm > mGalagoPro3AcpiEnableLib.c | 2 +- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/ > DxeBoardAcpiTableLib.c | 4 ++-- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/ > DxeKabylakeRvp3AcpiTableLib.c | 2 +- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/ > DxeMultiBoardAcpiSupportLib.c | 2 +- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/S > mmBoardAcpiEnableLib.c | 4 ++-- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/S > mmKabylakeRvp3AcpiEnableLib.c | 2 +- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/S > mmMultiBoardAcpiSupportLib.c | 2 +- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/S > mmSiliconAcpiEnableLib.c | 10 +++++----- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/P > eiBoardInitPostMemLib.c | 4 ++-- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/P > eiBoardInitPreMemLib.c | 2 +- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/P > eiMultiBoardInitPostMemLib.c | 2 +- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/P > eiMultiBoardInitPreMemLib.c | 2 +- > 16 files changed, 23 insertions(+), 23 deletions(-) > > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /DxeBoardAcpiTableLib.inf > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLi > b/DxeBoardAcpiTableLib.inf > index e7a30a726a..bfb58e868f 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /DxeBoardAcpiTableLib.inf > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpi > +++ Lib/DxeBoardAcpiTableLib.inf > @@ -1,5 +1,5 @@ > ### @file > -# Platform Hook Library instance for Kaby Lake RVP3. > +# Kaby Lake RVP 3 Board ACPI library > # > # Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR> # > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /DxeMultiBoardAcpiSupportLib.inf > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLi > b/DxeMultiBoardAcpiSupportLib.inf > index 0bd821ffbb..00cdbe80ce 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /DxeMultiBoardAcpiSupportLib.inf > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpi > +++ Lib/DxeMultiBoardAcpiSupportLib.inf > @@ -1,5 +1,5 @@ > ### @file > -# Platform Hook Library instance for Kaby Lake RVP3. > +# Kaby Lake RVP 3 Multi-Board ACPI Support library > # > # Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR> # > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /SmmBoardAcpiEnableLib.inf > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLi > b/SmmBoardAcpiEnableLib.inf > index cad0caa79c..46a714dc1d 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /SmmBoardAcpiEnableLib.inf > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpi > +++ Lib/SmmBoardAcpiEnableLib.inf > @@ -1,5 +1,5 @@ > ### @file > -# Platform Hook Library instance for Kaby Lake RVP3. > +# Kaby Lake RVP 3 SMM Board ACPI Enable library > # > # Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR> # > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /SmmMultiBoardAcpiSupportLib.inf > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLi > b/SmmMultiBoardAcpiSupportLib.inf > index 6628d30b6b..fca63c8314 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /SmmMultiBoardAcpiSupportLib.inf > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpi > +++ Lib/SmmMultiBoardAcpiSupportLib.inf > @@ -1,5 +1,5 @@ > ### @file > -# Platform Hook Library instance for Kaby Lake RVP3. > +# Kaby Lake RVP 3 SMM Multi-Board ACPI Support library > # > # Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR> # > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/S > mmGalagoPro3AcpiEnableLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/ > SmmGalagoPro3AcpiEnableLib.c > index 265c00551a..b984e25ce3 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/S > mmGalagoPro3AcpiEnableLib.c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLi > +++ b/SmmGalagoPro3AcpiEnableLib.c > @@ -1,5 +1,5 @@ > /** @file > - Platform Hook Library instances > + System 76 Galago Pro 3 Board ACPI Enable library > > Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> > SPDX-License-Identifier: BSD-2-Clause-Patent diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /DxeBoardAcpiTableLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLi > b/DxeBoardAcpiTableLib.c > index 60c11290c0..8699f8d403 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /DxeBoardAcpiTableLib.c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpi > +++ Lib/DxeBoardAcpiTableLib.c > @@ -1,7 +1,7 @@ > /** @file > - Platform Hook Library instances > + Kaby Lake RVP 3 Board ACPI library > > -Copyright (c) 2017, Intel Corporation. All rights reserved.<BR> > +Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR> > SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /DxeKabylakeRvp3AcpiTableLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLi > b/DxeKabylakeRvp3AcpiTableLib.c > index eceac3d037..d66283f7e8 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /DxeKabylakeRvp3AcpiTableLib.c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpi > +++ Lib/DxeKabylakeRvp3AcpiTableLib.c > @@ -1,5 +1,5 @@ > /** @file > - Platform Hook Library instances > + Kaby Lake RVP 3 Board ACPI Library > > Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR> > SPDX-License-Identifier: BSD-2-Clause-Patent diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /DxeMultiBoardAcpiSupportLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLi > b/DxeMultiBoardAcpiSupportLib.c > index 0c78342a1d..dfb1b028f1 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /DxeMultiBoardAcpiSupportLib.c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpi > +++ Lib/DxeMultiBoardAcpiSupportLib.c > @@ -1,5 +1,5 @@ > /** @file > - Platform Hook Library instances > + Kaby Lake RVP 3 Multi-Board ACPI Support library > > Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR> > SPDX-License-Identifier: BSD-2-Clause-Patent diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /SmmBoardAcpiEnableLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLi > b/SmmBoardAcpiEnableLib.c > index 3de0ae34a7..e89624ea03 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /SmmBoardAcpiEnableLib.c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpi > +++ Lib/SmmBoardAcpiEnableLib.c > @@ -1,7 +1,7 @@ > /** @file > - Platform Hook Library instances > + Kaby Lake RVP 3 SMM Board ACPI Enable library > > -Copyright (c) 2017, Intel Corporation. All rights reserved.<BR> > +Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR> > SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /SmmKabylakeRvp3AcpiEnableLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLi > b/SmmKabylakeRvp3AcpiEnableLib.c > index c9d0cda831..54755dd176 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /SmmKabylakeRvp3AcpiEnableLib.c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpi > +++ Lib/SmmKabylakeRvp3AcpiEnableLib.c > @@ -1,5 +1,5 @@ > /** @file > - Platform Hook Library instances > + Kaby Lake RVP 3 SMM Board ACPI Enable library > > Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR> > SPDX-License-Identifier: BSD-2-Clause-Patent diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /SmmMultiBoardAcpiSupportLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLi > b/SmmMultiBoardAcpiSupportLib.c > index 96eaf6e6e8..fb678a19bc 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /SmmMultiBoardAcpiSupportLib.c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpi > +++ Lib/SmmMultiBoardAcpiSupportLib.c > @@ -1,5 +1,5 @@ > /** @file > - Platform Hook Library instances > + Kaby Lake RVP 3 SMM Multi-Board ACPI Support library > > Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR> > SPDX-License-Identifier: BSD-2-Clause-Patent diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /SmmSiliconAcpiEnableLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLi > b/SmmSiliconAcpiEnableLib.c > index 185aa4ad2d..7f63a12bf4 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /SmmSiliconAcpiEnableLib.c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpi > +++ Lib/SmmSiliconAcpiEnableLib.c > @@ -1,7 +1,7 @@ > /** @file > - Platform Hook Library instances > + Kaby Lake RVP 3 SMM Silicon ACPI Enable library > > -Copyright (c) 2017, Intel Corporation. All rights reserved.<BR> > +Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR> > SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > @@ -68,7 +68,7 @@ SiliconEnableAcpi ( > PCI_DEVICE_NUMBER_PCH_LPC, > PCI_FUNCTION_NUMBER_PCH_LPC > ); > - > + > // > // Get the ACPI Base Address > // > @@ -127,7 +127,7 @@ SiliconEnableAcpi ( > OutputValue = IoRead32 (AcpiBaseAddr + 0x38); > OutputValue = OutputValue & ~(1 << (UINTN) PcdGet8 > (PcdSmcExtSmiBitPosition)); > IoWrite32 (AcpiBaseAddr + 0x38, OutputValue); > - > + > > // > // Enable SCI > @@ -149,7 +149,7 @@ SiliconDisableAcpi ( { > UINT16 AcpiBaseAddr; > UINT32 Pm1Cnt; > - > + > // > // Get the ACPI Base Address > // > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/ > PeiBoardInitPostMemLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib > /PeiBoardInitPostMemLib.c > index d88c4eb461..2e079a0387 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/ > PeiBoardInitPostMemLib.c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInit > +++ Lib/PeiBoardInitPostMemLib.c > @@ -1,7 +1,7 @@ > /** @file > - Platform Hook Library instances > + Kaby Lake RVP 3 Board Initialization Post-Memory library > > -Copyright (c) 2017, Intel Corporation. All rights reserved.<BR> > +Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR> > SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/ > PeiBoardInitPreMemLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib > /PeiBoardInitPreMemLib.c > index f1829c287d..f5c695ecff 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/ > PeiBoardInitPreMemLib.c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInit > +++ Lib/PeiBoardInitPreMemLib.c > @@ -1,5 +1,5 @@ > /** @file > - Platform Hook Library instances > + Kaby Lake RVP 3 Board Initialization Pre-Memory library > > Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR> > SPDX-License-Identifier: BSD-2-Clause-Patent diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/ > PeiMultiBoardInitPostMemLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib > /PeiMultiBoardInitPostMemLib.c > index 72cdeaa0b2..70e93e94da 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/ > PeiMultiBoardInitPostMemLib.c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInit > +++ Lib/PeiMultiBoardInitPostMemLib.c > @@ -1,5 +1,5 @@ > /** @file > - Platform Hook Library instances > + Kaby Lake RVP 3 Multi-Board Initialization Post-Memory library > > Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR> > SPDX-License-Identifier: BSD-2-Clause-Patent diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/ > PeiMultiBoardInitPreMemLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib > /PeiMultiBoardInitPreMemLib.c > index 3cf391c0bb..59b3177201 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/ > PeiMultiBoardInitPreMemLib.c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInit > +++ Lib/PeiMultiBoardInitPreMemLib.c > @@ -1,5 +1,5 @@ > /** @file > - Platform Hook Library instances > + Kaby Lake RVP 3 Multi-Board Initialization Pre-Memory library > > Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR> > SPDX-License-Identifier: BSD-2-Clause-Patent > -- > 2.16.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#49618): https://edk2.groups.io/g/devel/message/49618 Mute This Topic: https://groups.io/mt/39695976/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
