> -----Original Message----- > From: Zhang, Shenglei > Sent: Wednesday, October 16, 2019 9:47 AM > To: devel@edk2.groups.io > Cc: Wu, Hao A; Ni, Ray > Subject: [PATCH 2/3] MdeModulePkg/UhciPei: Initialize the variable > RequestMap > > RequestMap is used but not Initialized. > > Cc: Hao A Wu <hao.a...@intel.com> > Cc: Ray Ni <ray...@intel.com> > Signed-off-by: Shenglei Zhang <shenglei.zh...@intel.com> > --- > MdeModulePkg/Bus/Pci/UhciPei/UhcPeim.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/MdeModulePkg/Bus/Pci/UhciPei/UhcPeim.c > b/MdeModulePkg/Bus/Pci/UhciPei/UhcPeim.c > index b897c3f82ce6..a05834da3c4a 100644 > --- a/MdeModulePkg/Bus/Pci/UhciPei/UhcPeim.c > +++ b/MdeModulePkg/Bus/Pci/UhciPei/UhcPeim.c > @@ -274,6 +274,8 @@ UhcControlTransfer ( > > PktID = INPUT_PACKET_ID; > > + RequestMap = NULL;
Hello, Is this a real issue or just a false positive report by some compiler or static analyzer? If is a real issue, could you help to describe the issue in more detail? If it is a false positive report, could you help to add some comments together with the change? Thanks in advance. Best Regards, Hao Wu > + > if (Request == NULL || TransferResult == NULL) { > return EFI_INVALID_PARAMETER; > } > -- > 2.18.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#49634): https://edk2.groups.io/g/devel/message/49634 Mute This Topic: https://groups.io/mt/34556041/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-