Agreed. Will rename in V3.
Thanks! Chasel > -----Original Message----- > From: Kubacki, Michael A <[email protected]> > Sent: Thursday, October 31, 2019 1:50 PM > To: Chiu, Chasel <[email protected]>; [email protected] > Cc: Desimone, Nathaniel L <[email protected]>; Gao, Liming > <[email protected]>; Jeremy Soller <[email protected]>; Lu, Shifei A > <[email protected]>; Zhou, Bowen <[email protected]>; Oram, Isaac > W <[email protected]>; Wei, David Y <[email protected]>; > Agyeman, Prince <[email protected]> > Subject: RE: [edk2-platforms: PATCH v2 0/6] Add SetCacheLib library class. > > Hi Chasel, > > I don't think SetCacheLib is quite precise enough. Can you please consider > an alternative such as SetMtrrLib? > > Thanks, > Michael > > > -----Original Message----- > > From: Chiu, Chasel <[email protected]> > > Sent: Wednesday, October 30, 2019 5:30 PM > > To: [email protected] > > Cc: Kubacki, Michael A <[email protected]>; Desimone, > > Nathaniel L <[email protected]>; Gao, Liming > > <[email protected]>; Jeremy Soller <[email protected]>; Lu, > > Shifei A <[email protected]>; Zhou, Bowen <[email protected]>; > > Oram, Isaac W <[email protected]>; Wei, David Y > > <[email protected]>; Agyeman, Prince <[email protected]> > > Subject: [edk2-platforms: PATCH v2 0/6] Add SetCacheLib library class. > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2314 > > > > The MTRRs may be redundantly or incorrectly configured. > > It is recommended to move this functionality to a library class that > > with a NULL library by default. The board package may provide its own > > library implementation. > > MinPlatformPkg should contain the library class header (API) and the > > NULL library class instance. > > > > Cc: Michael Kubacki <[email protected]> > > Cc: Nate DeSimone <[email protected]> > > Cc: Liming Gao <[email protected]> > > Cc: Jeremy Soller <[email protected]> > > Cc: Shifei A Lu <[email protected]> > > Cc: Xiaohu Zhou <[email protected]> > > Cc: Isaac W Oram <[email protected]> > > Cc: Wei David Y <[email protected]> > > Cc: Agyeman Prince <[email protected]> > > Signed-off-by: Chasel Chiu <[email protected]> > > > > Chasel Chiu (6): > > MinPlatformPkg: Add SetCacheLib library class. > > MinPlatformPkg: Add SetCacheLib library class. > > KabylakeOpenBoardPkg: Add SetCacheLib library class. > > WhiskeylakeOpenBoardPkg: Add SetCacheLib library class. > > PurleyOpenBoardPkg/BoardMtOlympus: Add SetCacheLib library class. > > SimicsOpenBoardPkg/BoardX58Ich10: Add SetCacheLib library class. > > > > > > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel > > /MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c | > 640 > > ---------------------------------------------------------------------- > > ------------------------ > > ---------------------------------------------------------------------- > > ------------------------ > > ---------------------------------------------------------------------- > > ------------------------ > > ---------------------------------------------------------------------- > > ------------------------ > > ---------------------------------------------------------------------- > > ------------------------ > > ---------------------------------------------------------------------- > > ------------------------ > > ---------------------------------------------------------------------- > > ------ > > Platform/Intel/MinPlatformPkg/Library/SetCacheLib/SetCacheLib.c > > | 325 > > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > +++++++++++++++++++++++++++++++++++ > > Platform/Intel/MinPlatformPkg/Library/SetCacheLib/SetCacheLibNull.c > > | 37 +++++++++++++++++++++++++++++++++++++ > > > > > Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPos > > tMem.c > | 149 +----------------------------------------- > > ---------------------------------------------------------------------- > > ------------------------ > > ------------- > > > > > Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPre > > Mem.c > | 164 ++---------------------------------------- > > ---------------------------------------------------------------------- > > ------------------------ > > ---------------------------- > > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > > | 3 ++- > > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf > > | 2 +- > > > > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel > > /MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf | > > 67 > > ------------------------------------------------------------------- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc > > | 1 + > > Platform/Intel/MinPlatformPkg/Include/Library/SetCacheLib.h > > | 34 ++++++++++++++++++++++++++++++++++ > > Platform/Intel/MinPlatformPkg/Library/SetCacheLib/SetCacheLib.inf > > | 44 ++++++++++++++++++++++++++++++++++++++++++++ > > Platform/Intel/MinPlatformPkg/Library/SetCacheLib/SetCacheLibNull.inf > > | 30 ++++++++++++++++++++++++++++++ > > > > > Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPos > > tMem.inf > | 11 +---------- > > > > > Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPre > > Mem.inf > | 7 ++----- > > Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkg.dsc > > | 3 ++- > > Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc > > | 1 + > > > > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPk > > g.dsc > | 1 + > > 17 files changed, 484 insertions(+), 1035 deletions(-) delete mode > > 100644 > > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel > > /MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c > > create mode 100644 > > Platform/Intel/MinPlatformPkg/Library/SetCacheLib/SetCacheLib.c > > create mode 100644 > > Platform/Intel/MinPlatformPkg/Library/SetCacheLib/SetCacheLibNull.c > > delete mode 100644 > > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel > > /MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf > > create mode 100644 > > Platform/Intel/MinPlatformPkg/Include/Library/SetCacheLib.h > > create mode 100644 > > Platform/Intel/MinPlatformPkg/Library/SetCacheLib/SetCacheLib.inf > > create mode 100644 > > Platform/Intel/MinPlatformPkg/Library/SetCacheLib/SetCacheLibNull.inf > > > > -- > > 2.13.3.windows.1 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#49750): https://edk2.groups.io/g/devel/message/49750 Mute This Topic: https://groups.io/mt/40049897/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
