On Mon, Oct 28, 2019 at 10:01:49 +0800, Abner Chang wrote: > RAM based Firmware Volume Block service runtime driver for U5 series > platforms.
For this patch, could you please update the commit message to describe what this is and what it is used for? This includes one more item below. > Signed-off-by: Abner Chang <[email protected]> > > Cc: Michael D Kinney <[email protected]> > Cc: Ard Biesheuvel <[email protected]> > Cc: Leif Lindholm <[email protected]> > Cc: Gilbert Chen <[email protected]> > Cc: Palmer Dabbelt <[email protected]> > --- > .../FvbServicesRuntimeDxe.inf | 80 ++ > .../Dxe/RamFvbServicesRuntimeDxe/FwBlockService.h | 187 ++++ > .../Dxe/RamFvbServicesRuntimeDxe/RamFlash.h | 85 ++ > .../Dxe/RamFvbServicesRuntimeDxe/FvbInfo.c | 127 +++ > .../Dxe/RamFvbServicesRuntimeDxe/FwBlockService.c | 1114 > ++++++++++++++++++++ > .../RamFvbServicesRuntimeDxe/FwBlockServiceDxe.c | 150 +++ > .../Dxe/RamFvbServicesRuntimeDxe/RamFlash.c | 145 +++ > .../Dxe/RamFvbServicesRuntimeDxe/RamFlashDxe.c | 20 + > 8 files changed, 1908 insertions(+) > create mode 100644 > Platform/SiFive/U5SeriesPkg/Universal/Dxe/RamFvbServicesRuntimeDxe/FvbServicesRuntimeDxe.inf > create mode 100644 > Platform/SiFive/U5SeriesPkg/Universal/Dxe/RamFvbServicesRuntimeDxe/FwBlockService.h > create mode 100644 > Platform/SiFive/U5SeriesPkg/Universal/Dxe/RamFvbServicesRuntimeDxe/RamFlash.h > create mode 100644 > Platform/SiFive/U5SeriesPkg/Universal/Dxe/RamFvbServicesRuntimeDxe/FvbInfo.c > create mode 100644 > Platform/SiFive/U5SeriesPkg/Universal/Dxe/RamFvbServicesRuntimeDxe/FwBlockService.c > create mode 100644 > Platform/SiFive/U5SeriesPkg/Universal/Dxe/RamFvbServicesRuntimeDxe/FwBlockServiceDxe.c > create mode 100644 > Platform/SiFive/U5SeriesPkg/Universal/Dxe/RamFvbServicesRuntimeDxe/RamFlash.c > create mode 100644 > Platform/SiFive/U5SeriesPkg/Universal/Dxe/RamFvbServicesRuntimeDxe/RamFlashDxe.c > > diff --git > a/Platform/SiFive/U5SeriesPkg/Universal/Dxe/RamFvbServicesRuntimeDxe/FvbServicesRuntimeDxe.inf > > b/Platform/SiFive/U5SeriesPkg/Universal/Dxe/RamFvbServicesRuntimeDxe/FvbServicesRuntimeDxe.inf > new file mode 100644 > index 0000000..9db112a > --- /dev/null > +++ > b/Platform/SiFive/U5SeriesPkg/Universal/Dxe/RamFvbServicesRuntimeDxe/FvbServicesRuntimeDxe.inf > @@ -0,0 +1,80 @@ > +## @file > +# Component description file for RAM Flash Fimware Volume Block DXE driver > +# module. > +# > +# This DXE runtime driver implements and produces the Fimware Volue Block > +# Protocol for a RAM flash device. > +# > +# Copyright (c) 2019, Hewlett Packard Enterprise Development LP. All rights > reserved.<BR> > +# > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +## > + > +[Defines] > + INF_VERSION = 0x0001001b > + BASE_NAME = FvbServicesRuntimeDxe > + FILE_GUID = B04036D3-4C60-43D6-9850-0FCC090FF054 > + MODULE_TYPE = DXE_RUNTIME_DRIVER > + VERSION_STRING = 1.0 > + ENTRY_POINT = FvbInitialize > + > +# > +# The following information is for reference only and not required by the > build > +# tools. > +# > +# VALID_ARCHITECTURES = RISCV64 > +# > + > +[Sources] > + FvbInfo.c > + FwBlockService.c > + FwBlockServiceDxe.c > + RamFlash.c > + RamFlashDxe.c > + > +[Packages] > + MdePkg/MdePkg.dec > + MdeModulePkg/MdeModulePkg.dec > + RiscVPlatformPkg/RiscVPlatformPkg.dec > + > +[LibraryClasses] > + BaseLib > + BaseMemoryLib > + DebugLib > + DevicePathLib > + DxeServicesTableLib > + MemoryAllocationLib > + PcdLib > + UefiBootServicesTableLib > + UefiDriverEntryPoint > + UefiRuntimeLib > + > +[Guids] > + gEfiEventVirtualAddressChangeGuid # ALWAYS_CONSUMED > + # gEfiEventVirtualAddressChangeGuid # Create Event: EVENT_GROUP_GUID > + > +[Protocols] > + gEfiFirmwareVolumeBlockProtocolGuid # PROTOCOL SOMETIMES_PRODUCED > + gEfiDevicePathProtocolGuid # PROTOCOL SOMETIMES_PRODUCED > + > +[FixedPcd] > + gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize > + gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingSize > + gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareSize > + > + gUefiRiscVPlatformPkgTokenSpaceGuid.PcdPlatformFlashNvStorageVariableBase > + gUefiRiscVPlatformPkgTokenSpaceGuid.PcdPlatformFlashNvStorageFtwWorkingBase > + gUefiRiscVPlatformPkgTokenSpaceGuid.PcdPlatformFlashNvStorageFtwSpareBase > + gUefiRiscVPlatformPkgTokenSpaceGuid.PcdVariableFdBaseAddress > + gUefiRiscVPlatformPkgTokenSpaceGuid.PcdVariableFdSize > + gUefiRiscVPlatformPkgTokenSpaceGuid.PcdVariableFdBlockSize > + > +[Pcd] > + gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingBase > + gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareBase > + gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase > + gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase64 > + > +[Depex] > + TRUE > diff --git > a/Platform/SiFive/U5SeriesPkg/Universal/Dxe/RamFvbServicesRuntimeDxe/FwBlockService.h > > b/Platform/SiFive/U5SeriesPkg/Universal/Dxe/RamFvbServicesRuntimeDxe/FwBlockService.h > new file mode 100644 > index 0000000..96d0141 > --- /dev/null > +++ > b/Platform/SiFive/U5SeriesPkg/Universal/Dxe/RamFvbServicesRuntimeDxe/FwBlockService.h > @@ -0,0 +1,187 @@ > +/**@file > + > + Copyright (c) 2019, Hewlett Packard Enterprise Development LP. All rights > reserved.<BR> > + Copyright (c) 2006, Intel Corporation. All rights reserved.<BR> > + > + SPDX-License-Identifier: BSD-2-Clause-Patent > + > + Module Name: > + > + FwBlockService.h > + > + Abstract: > + > + Firmware volume block driver for Intel Firmware Hub (FWH) device The FWH comment is surely incorrect here? Please describe the thing actually implemented. No need to resubmit - just update in your repo and I will grab it from there when I get to pushing this port to a -devel branch. / Leif -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#51283): https://edk2.groups.io/g/devel/message/51283 Mute This Topic: https://groups.io/mt/38832050/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
