Hi Anthony, I fixed this issue at edk2 master.
Thanks, Bob -----Original Message----- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Anthony PERARD Sent: Monday, December 16, 2019 10:14 PM To: devel@edk2.groups.io; Feng, Bob C <bob.c.f...@intel.com> Cc: Gao, Liming <liming....@intel.com>; Shi, Steven <steven....@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com> Subject: Re: [edk2-devel] [Patch 1/4 V6] BaseTools: Add build option for dependency file generation On Fri, Dec 06, 2019 at 11:26:55PM +0800, Bob Feng wrote: > BaseTools/Conf/tools_def.template | 181 > ++++++++++++++++-------------- Hi Bob, That patch introduces the first two UTF-8 characters (the quote ’ ) in an otherwise all-ascii file. And that prevent our CI from building OVMF. Part of the error log: Running edk2 build for OvmfPkgX64 build.py... : error 0001: File open failure /home/osstest/build.144860.build-amd64/xen/tools/firmware/ovmf-dir-remote/Conf/tools_def.txt Traceback (most recent call last): File "/home/osstest/build.144860.build-amd64/xen/tools/firmware/ovmf-dir-remote/BaseTools/Source/Python/Common/ToolDefClassObject.py", line 117, in IncludeToolDefFile FileContent = F.readlines() File "/usr/lib/python3.5/encodings/ascii.py", line 26, in decode return codecs.ascii_decode(input, self.errors)[0] UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 2289: ordinal not in range(128) Full build log can be found here, with ovmf build near the bottom: http://logs.test-lab.xenproject.org/osstest/logs/144860/build-amd64/6.ts-xen-build.log Should we replaces the two offending quotes by proper ascii quotes? Or should we fix IncludeToolDefFile to always use UTF-8 decoding? Or both? Thanks, -- Anthony PERARD -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52321): https://edk2.groups.io/g/devel/message/52321 Mute This Topic: https://groups.io/mt/67482143/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
