> -----Original Message----- > From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com] > Sent: Tuesday, January 7, 2020 3:10 PM > To: Gao, Zhichao <zhichao....@intel.com>; devel@edk2.groups.io > Cc: Ni, Ray <ray...@intel.com> > Subject: Re: [PATCH v2 0/2] ShellPkg: Document the use of > EFI_INVALID_PARAMETER by two functions > > Hi Zhichao, > > On 1/7/20 8:01 AM, Gao, Zhichao wrote: > > Sorry for late response: > > > >> -----Original Message----- > >> From: Philippe Mathieu-Daude <phi...@redhat.com> > >> Sent: Thursday, December 19, 2019 10:10 PM > >> To: devel@edk2.groups.io > >> Cc: Ni, Ray <ray...@intel.com>; Gao, Zhichao <zhichao....@intel.com>; > >> Philippe Mathieu-Daude <phi...@redhat.com> > >> Subject: [PATCH v2 0/2] ShellPkg: Document the use of > >> EFI_INVALID_PARAMETER by two functions > >> > >> Complete the list of values the functios ParseCommandLineToArgs() and > >> UpdateArgcArgv() can return. > >> > >> The documentation was found to be incomplete while reviewing BZ#2395: > >> https://edk2.groups.io/g/devel/message/51512 > >> > >> v2: > >> - Shortened patch #1 subject to fit 72 chars > > > > The subject should be less than 72 chars (do not include 72 chars). > > What is the rationale for this restriction? Some tool limitation?
Yes. There is a patch check tool in BaseTools\Scripts\ PatchCheck.py. And the patch #1 can't pass the check. Thanks, Zhichao -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52957): https://edk2.groups.io/g/devel/message/52957 Mute This Topic: https://groups.io/mt/68831521/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
