> -----Original Message----- > From: Albecki, Mateusz > Sent: Tuesday, January 07, 2020 7:06 PM > To: devel@edk2.groups.io > Cc: Albecki, Mateusz; Wu, Hao A; Marcin Wojtas; Gao, Zhichao; Gao, Liming > Subject: [PATCH 0/3] MdeModulePkg/SdMmcPciHcDxe: Retry the > commands that failed due to CRC error > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1140 > > Some of the boards report that just after we change the clock frequency to > 200MHz link is > unable to stabilize fast enough and when driver sends the CMD13 it will often > fail > randomly with CRC error. To protect against this kind of random failures this > patch > series will make the driver retry the commands that failed due to random > CRC errors. > > Since async code has not yet been tested it has been put into separate patch. > That patch > is not needed to solve most pressing CMD13 issues. > > Tets performed: > -Boot eMMC in HS400 > -Boot eMMC in HS400 with simulated CRC error on every first CMD13
Hello Mateusz, Thanks for the contribution. Please grant me some time to review and validate the series. I will try to give my feedbacks no later than early next week. Best Regards, Hao Wu > > Cc: Hao A Wu <hao.a...@intel.com> > Cc: Marcin Wojtas <m...@semihalf.com> > Cc: Zhichao Gao <zhichao....@intel.com> > Cc: Liming Gao <liming....@intel.com> > > Signed-off-by: Mateusz Albecki <mateusz.albe...@intel.com> > > Mateusz Albecki (3): > MdeModulePkg/SdMmcPciHcDxe: Refactor command error detection > MdeModulePkg/SdMmcPciHcDxe: Add retries for sync commands > MdeModulePkg/SdMmcPciHcDxe: Add retries for async commands > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 89 +++++--- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 5 +- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 235 > ++++++++++++++------- > 3 files changed, 221 insertions(+), 108 deletions(-) > > -- > 2.14.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#53005): https://edk2.groups.io/g/devel/message/53005 Mute This Topic: https://groups.io/mt/69499844/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
