> -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Wu, Hao A > Sent: Wednesday, January 15, 2020 9:50 AM > To: devel@edk2.groups.io; Albecki, Mateusz > Cc: Marcin Wojtas; Gao, Zhichao; Gao, Liming > Subject: Re: [edk2-devel] [PATCHv2 0/4] MdeModulePkg/SdMmcPciHcDxe: > Retry the commands that failed due to CRC error > > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Albecki, Mateusz > > Sent: Tuesday, January 14, 2020 8:05 PM > > To: devel@edk2.groups.io > > Cc: Albecki, Mateusz; Wu, Hao A; Marcin Wojtas; Gao, Zhichao; Gao, Liming > > Subject: [edk2-devel] [PATCHv2 0/4] MdeModulePkg/SdMmcPciHcDxe: > > Retry the commands that failed due to CRC error > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1140 > > > > Some of the boards report that just after we change the clock frequency to > > 200MHz link is unable to stabilize fast enough and when driver sends the > > CMD13 it will often fail randomly with CRC error. To protect against this > > kind > > of random failures this patch series will make the driver retry the > commands > > that failed due to random CRC errors. > > > > Since async code has not yet been tested it has been put into separate > patch. > > That patch is not needed to solve most pressing CMD13 issues. > > > > changes in v2: > > -Split first patch into bugfix and refactor > > -Normal interrupt status register will now only be read once during > > SdMmcCheckTrbResult > > -We will no longer clear the data transfer timeout error in > > SdMmcCheckAndRecoverErrors. Instead we will immedieatly return for > such > > case and register reset will be done in next SdMmcExecTrb > > > > Tets performed: > > -Boot eMMC in HS400 > > -Boot eMMC in HS400 with simulated CRC error on every first CMD13 > > > For the series, > Reviewed-by: Hao A Wu <hao.a...@intel.com> > > I will wait a couple of days to see if there are comments from other > reviewers > before pushing the series.
Series pushed via commits c40c6351fa..430743a1e8. Best Regards, Hao Wu > > Best Regards, > Hao Wu > > > > > > Cc: Hao A Wu <hao.a...@intel.com> > > Cc: Marcin Wojtas <m...@semihalf.com> > > Cc: Zhichao Gao <zhichao....@intel.com> > > Cc: Liming Gao <liming....@intel.com> > > > > Signed-off-by: Mateusz Albecki <mateusz.albe...@intel.com> > > > > > > Mateusz Albecki (4): > > MdeModulePkg/SdMmcPciHcDxe: Fix DAT lane SW reset > > MdeModulePkg/SdMmcPciHcDxe: Refactor command error detection > > MdeModulePkg/SdMmcPciHcDxe: Add retries for sync commands > > MdeModulePkg/SdMmcPciHcDxe: Add retries for async commands > > > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 89 > ++++++-- > > - > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 5 +- > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 218 > > ++++++++++++++------- > > 3 files changed, 204 insertions(+), 108 deletions(-) > > > > -- > > 2.14.1.windows.1 > > > > -------------------------------------------------------------------- > > > > Intel Technology Poland sp. z o.o. > > ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII > > Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP > 957- > > 07-52-316 | Kapital zakladowy 200.000 PLN. > > > > Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego > > adresata i moze zawierac informacje poufne. W razie przypadkowego > > otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale > > jej usuniecie; jakiekolwiek > > przegladanie lub rozpowszechnianie jest zabronione. > > This e-mail and any attachments may contain confidential material for the > > sole use of the intended recipient(s). If you are not the intended > > recipient, > > please contact the sender and delete all copies; any review or distribution > by > > others is strictly prohibited. > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#53381): https://edk2.groups.io/g/devel/message/53381 Mute This Topic: https://groups.io/mt/69691992/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
