Please change the Copyright year to 2020, with that: Reviewed-by: Siyuan Fu <[email protected]>
> -----Original Message----- > From: Armour, Nicholas <[email protected]> > Sent: 2020年2月20日 6:53 > To: [email protected] > Cc: Armour, Nicholas <[email protected]>; Wu, Jiaxin > <[email protected]>; Maciej Rabeda <[email protected]>; Fu, > Siyuan <[email protected]> > Subject: [PATCH v3 1/1] NetworkPkg/ArpDxe: Recycle invalid ARP packets > (CVE-2019-14559) > > Fixing subject line > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2031 > > This patch triggers the RecycleEvent for invalid ARP packets. > Prior to this, we would just ignore invalid ARP packets, > and never free them. > > Cc: Jiaxin Wu <[email protected]> > Cc: Maciej Rabeda <[email protected]> > Cc: Siyuan Fu <[email protected]> > Signed-off-by: Nicholas Armour <[email protected]> > --- > NetworkPkg/ArpDxe/ArpImpl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/NetworkPkg/ArpDxe/ArpImpl.c b/NetworkPkg/ArpDxe/ArpImpl.c > index 9cdb33f2bd66..703fe20cc892 100644 > --- a/NetworkPkg/ArpDxe/ArpImpl.c > +++ b/NetworkPkg/ArpDxe/ArpImpl.c > @@ -113,7 +113,7 @@ ArpOnFrameRcvdDpc ( > // > // Restart the receiving if packet size is not correct. > // > - goto RESTART_RECEIVE; > + goto RECYCLE_RXDATA; > } > > // > @@ -125,7 +125,7 @@ ArpOnFrameRcvdDpc ( > Head->OpCode = NTOHS (Head->OpCode); > > if (RxData->DataLength < (sizeof (ARP_HEAD) + 2 * Head->HwAddrLen + 2 * > Head->ProtoAddrLen)) { > - goto RESTART_RECEIVE; > + goto RECYCLE_RXDATA; > } > > if ((Head->HwType != ArpService->SnpMode.IfType) || > -- > 2.16.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#54651): https://edk2.groups.io/g/devel/message/54651 Mute This Topic: https://groups.io/mt/71408593/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
