Reviewed-by: Michael D Kinney <michael.d.kin...@intel.com> Mike
> -----Original Message----- > From: Jiang, Guomin <guomin.ji...@intel.com> > Sent: Monday, March 23, 2020 6:43 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; > Gao, Liming <liming....@intel.com> > Subject: [PATCH v4] MdePkg/UnitTestBaseLib: Add check > for pointer BinData > > REF: > https://bugzilla.tianocore.org/show_bug.cgi?id=2531 > > AllocatePool may fail and BinData may be invalid, check > it before use. > > Cc: Michael D Kinney <michael.d.kin...@intel.com> > Cc: Liming Gao <liming....@intel.com> > Signed-off-by: Guomin Jiang <guomin.ji...@intel.com> > --- > MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c > | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git > a/MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c > b/MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c > index 6f7c31cab4..8952f9da6c 100644 > --- > a/MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c > +++ > b/MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c > @@ -252,9 +252,11 @@ RfcDecodeTest( > BinSize = AsciiStrnLenS (binString, > MAX_TEST_STRING_SIZE); > > > > BinData = AllocatePool (BinSize); > > - Btc->BufferToFree = BinData; > > + UT_ASSERT_NOT_NULL(BinData); > > > > + Btc->BufferToFree = BinData; > > ReturnSize = BinSize; > > + > > Status = Base64Decode (b64String, b64StringLen, > BinData, &ReturnSize); > > > > UT_ASSERT_STATUS_EQUAL (Status, Btc- > >ExpectedStatus); > > -- > 2.25.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#56160): https://edk2.groups.io/g/devel/message/56160 Mute This Topic: https://groups.io/mt/72508893/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
