On Wed, 25 Mar 2020 at 11:53, Aditya Angadi <aditya.ang...@arm.com> wrote:
>
> Add information in the SGI platform descriptor HOB to pick the correct
> ACPI table to install for RD-Daniel Config-M
>
This description does not make sense. You are adding a completely new
SGI flavour called 'Daniel' in this patch, right? Please make that a
separate patch.
> Cc: Leif Lindholm <l...@nuviainc.com>
> Cc: Ard Biesheuvel <ard.biesheu...@linaro.org>
> Signed-off-by: Aditya Angadi <aditya.ang...@arm.com>
> ---
> Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 5 +++
> Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf | 1 +
> Platform/ARM/SgiPkg/Include/SgiPlatform.h | 4 +++
> Platform/ARM/SgiPkg/RdDaniel.dsc | 37
> ++++++++++++++++++++
> 4 files changed, 47 insertions(+)
>
> diff --git a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c
> b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c
> index 387397d74598..7e0de765f753 100644
> --- a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c
> +++ b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c
> @@ -46,6 +46,11 @@ STATIC SGI_PLATFORM_ACPI_TABLE_GUID_LOOKUP
> AcpiTableGuidLookup[] = {
> RD_E1_EDGE_CONF_ID,
> MULTI_CHIP_MODE_DISABLED,
> &gRdE1EdgeAcpiTablesFileGuid),
> + ACPI_GUID_LOOKUP (
> + RD_DANIEL_PART_NUM,
> + RD_DANIEL_CFGM_CONF_ID,
> + MULTI_CHIP_MODE_DISABLED,
> + &gRdDanielCfgMAcpiTablesFileGuid),
> };
>
> VOID
> diff --git a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf
> b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf
> index 741dcc75ed6a..82569820b78c 100644
> --- a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf
> +++ b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf
> @@ -34,6 +34,7 @@ [Guids]
> gRdN1EdgeAcpiTablesFileGuid
> gRdN1EdgeX2AcpiTablesFileGuid
> gRdE1EdgeAcpiTablesFileGuid
> + gRdDanielCfgMAcpiTablesFileGuid
>
> [FeaturePcd]
> gArmSgiTokenSpaceGuid.PcdVirtioBlkSupported
> diff --git a/Platform/ARM/SgiPkg/Include/SgiPlatform.h
> b/Platform/ARM/SgiPkg/Include/SgiPlatform.h
> index d87fb2b5409f..b6a427b8b657 100644
> --- a/Platform/ARM/SgiPkg/Include/SgiPlatform.h
> +++ b/Platform/ARM/SgiPkg/Include/SgiPlatform.h
> @@ -70,6 +70,10 @@
> #define RD_N1_EDGE_CONF_ID 0x1
> #define RD_E1_EDGE_CONF_ID 0x2
>
> +//RDDANIEL Platform Identification values
> +#define RD_DANIEL_PART_NUM 0x78A
> +#define RD_DANIEL_CFGM_CONF_ID 0x1
> +
> #define SGI_CONFIG_MASK 0x0F
> #define SGI_CONFIG_SHIFT 0x1C
> #define SGI_PART_NUM_MASK 0xFFF
> diff --git a/Platform/ARM/SgiPkg/RdDaniel.dsc
> b/Platform/ARM/SgiPkg/RdDaniel.dsc
> new file mode 100644
> index 000000000000..83e7ccd0bc05
> --- /dev/null
> +++ b/Platform/ARM/SgiPkg/RdDaniel.dsc
> @@ -0,0 +1,37 @@
> +#
> +# Copyright (c) 2020, ARM Limited. All rights reserved.
> +#
> +# SPDX-License-Identifier: BSD-2-Clause-Patent
> +#
> +
> +################################################################################
> +#
> +# Defines Section - statements that will be processed to create a Makefile.
> +#
> +################################################################################
> +[Defines]
> + PLATFORM_NAME = ArmSgi
> + PLATFORM_GUID = d301ac4e-0828-4cef-b754-34ca9b6781b5
> + PLATFORM_VERSION = 0.1
> + DSC_SPECIFICATION = 0x0001001B
> + OUTPUT_DIRECTORY = Build/$(PLATFORM_NAME)
> + SUPPORTED_ARCHITECTURES = AARCH64|ARM
> + BUILD_TARGETS = NOOPT|DEBUG|RELEASE
> + SKUID_IDENTIFIER = DEFAULT
> + FLASH_DEFINITION = Platform/ARM/SgiPkg/SgiPlatform.fdf
> + BUILD_NUMBER = 1
> +
> +# include common definitions from SgiPlatform.dsc
> +!include Platform/ARM/SgiPkg/SgiPlatform.dsc
> +
> +################################################################################
> +#
> +# Pcd Section - list of all EDK II PCD Entries defined by this Platform
> +#
> +################################################################################
> +
> +[PcdsFixedAtBuild.common]
> + # GIC Base Addresses
> + gArmTokenSpaceGuid.PcdGicDistributorBase|0x30000000
> + gArmTokenSpaceGuid.PcdGicRedistributorsBase|0x30140000
> + gArmSgiTokenSpaceGuid.PcdGicSize|0x200000
> --
> 2.17.1
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#56739): https://edk2.groups.io/g/devel/message/56739
Mute This Topic: https://groups.io/mt/72538025/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
