I have those options set correctly in git config.
After a quick look, as far as I can tell, this is because the Message-Id
in my email is modified such the the In-Reply-To and References headers
do not refer to the actual Message-Id in the cover letter:
Cover letter:
Subject: [edk2-devel] [PATCH v3 0/3] Return GetVariable() attr if
EFI_BUFFER_TOO_SMALL
Date: Fri, 27 Mar 2020 14:55:33 -0700
Message-Id: <160047f24e1d38f5.15...@groups.io>
The original Message-Id in the cover letter was moved to
X-Microsoft-Original-Message-Id:
X-Microsoft-Original-Message-ID:
<20200327215536.9556-1-michael.kuba...@outlook.com>
The first patch in the series:
Subject: [edk2-devel] [PATCH v3 1/3] MdeModulePkg Variable: Return
GetVariable() attr if EFI_BUFFER_TOO_SMALL
Date: Fri, 27 Mar 2020 14:55:34 -0700
Message-Id: <160047f33e58ad06.17...@groups.io>
In-Reply-To: <20200327215536.9556-1-michael.kuba...@outlook.com>
References: <20200327215536.9556-1-michael.kuba...@outlook.com>
Please let me know if you have suggestions. I'll look into it more.
Thanks,
Michael
On 3/31/2020 4:55 PM, Laszlo Ersek wrote:
Hi Michael,
On 03/27/20 22:55, Michael Kubacki wrote:
From: Michael Kubacki <michael.kuba...@microsoft.com>
This patch series updates the GetVariable() implementation
to return Attributes in the case EFI_BUFFER_TOO_SMALL is returned.
* [PATCH v3 1/3] Makes the functional change in the DXE/MM variable driver.
* [PATCH v3 2/3] Makes the functional change in the PEI variable driver.
* [PATCH v3 3/3] Removes a change made in NetworkPkg that worked around the
previous behavior when EFI_BUFFER_TOO_SMALL is returned.
V3 changes:
* Apply the same GetVariable() behavior in VariablePei so it is consistent
with the DXE/MM variable driver implementation.
Can you please configure your git-send-email machinery to post patch
series with "shallow threading"? Otherwise the patch emails are not
linked under the cover letter, and they fly apart.
I'm asking in particular because this series modifies both MdeModulePkg
and NetworkPkg. In such cases usually one of the affected maintainers
volunteers for merging the full set (once review is complete for the
entire set). And collecting the individual patches without proper
shallow threading is very difficult.
The git options are the following:
git config sendemail.chainreplyto false
git config sendemail.thread true
They are also put in place (with many other useful settings) by
"BaseTools/Scripts/SetupGit.py".
Or is there another problem with posting the patches? (I assume you post
the full set with a single git-send-email invocation.)
Thanks!
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#56807): https://edk2.groups.io/g/devel/message/56807
Mute This Topic: https://groups.io/mt/72598883/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-