Reviewed-by: Ashley DeSimone <ashley.e.desim...@intel.com>
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Nate DeSimone
Sent: Friday, April 3, 2020 4:27 PM
To: devel@edk2.groups.io
Cc: Desimone, Ashley E <ashley.e.desim...@intel.com>; Pandya, Puja
<puja.pan...@intel.com>; Bjorge, Erik C <erik.c.bjo...@intel.com>; Agyeman,
Prince <prince.agye...@intel.com>; Bret Barkelew <bret.barke...@microsoft.com>;
Philippe Mathieu-Daude <phi...@redhat.com>
Subject: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Checkout command
is broken
Fixes a bug where function call to combinations_in_manifest() was missing a
required parameter.
Signed-off-by: Nate DeSimone <nathaniel.l.desim...@intel.com>
Cc: Ashley DeSimone <ashley.e.desim...@intel.com>
Cc: Puja Pandya <puja.pan...@intel.com>
Cc: Erik Bjorge <erik.c.bjo...@intel.com>
Cc: Prince Agyeman <prince.agye...@intel.com>
Cc: Bret Barkelew <bret.barke...@microsoft.com>
Cc: Philippe Mathieu-Daude <phi...@redhat.com>
---
edkrepo/common/common_repo_functions.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/edkrepo/common/common_repo_functions.py
b/edkrepo/common/common_repo_functions.py
index 160127b..0d39291 100644
--- a/edkrepo/common/common_repo_functions.py
+++ b/edkrepo/common/common_repo_functions.py
@@ -563,7 +563,7 @@ def checkout(combination_or_sha, verbose=False,
override=False, log=None):
combo_or_sha = combination_or_sha
try:
# Try to handle normalize combo name to match the manifest file.
- combo_or_sha = case_insensitive_single_match(combo_or_sha,
combinations_in_manifest())
+ combo_or_sha = case_insensitive_single_match(combo_or_sha,
+ combinations_in_manifest(manifest))
except:
# No match so leave it alone. It must be a SHA1 or a bad combo name.
pass
--
2.26.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#56995): https://edk2.groups.io/g/devel/message/56995
Mute This Topic: https://groups.io/mt/72761502/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
