On 3/27/2020 1:01 PM, Laszlo Ersek wrote:
I'm quite happy about this patch, but perhaps for an unexpected reason: namely, because it showcases how non-intuitive and unpredictable it can be to customize existent code for a new platform.
Thanks! I was wondering if I should try and add new code into OvmfPkg, or keep it separate. Also, good point about the commit message: I get frustrated when people don't write proper/full messages, so I'm happy you called me out on it.
The existing bhyve port removes everything related to QemuFwCfgLib, such as calls to QemuFwCfgFindFile in PciHostBridgeLib.c. I'm not sure how I should proceed given that there's so much commonality between the ovmf and bhyve versions of the file: currently calls to QemuFwCfgFindFile don't resolve since references are absent from the .dsc file, so I'm wondering if I should re-add it, add a "#ifndef BHYVE" or similar to avoid attempting to compile that code, or duplicate the file with that code removed?
-- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#57097): https://edk2.groups.io/g/devel/message/57097 Mute This Topic: https://groups.io/mt/72550105/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
