> > --- > > .../SerialUartClockLib/SerialUartClockLib.c | 27 +++++++++++++++++++ > > .../SerialUartClockLib/SerialUartClockLib.inf | 26 ++++++++++++++++++ > > I requested after the initial submission that you "either follow the > manual git setup steps from > https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt- > git-guide-for-edk2-contributors-and-maintainers > or execute edk2/BaseTools/Scripts/SetupGit.py in each of the tianocore > repositories" > > Now, neither appears to have happened, as .c still comes before .inf > and paths are still truncated. > > But in addition to that, we realised that git happily ignores settings > for --stat. So, please, execute aforementioned script, but then > generate v3 with --stat=1000 --stat-graph-width=20. >
I am preparing the v3 of patches, and I am still seeing this issue after running SetupGit.py again. After some tinkering I figured out the problem. The git diff is ignoring the diff.Orderfile The reason is line ending of edk2/BaseTools/Conf/diff.order The current line ending of diff.order is windows, while I am using Linux to prepare patches. If I change it to unix (dos2unix), then git is able to show proper diff I wonder if same problem is with edk2/BaseTools/Conf/gitattributes ? Looks like SetupGit.py needs to be modified to take into account the git running environment. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#57274): https://edk2.groups.io/g/devel/message/57274 Mute This Topic: https://groups.io/mt/72077432/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
