Reviewed-by: Andrei Warkentin <andrey.warken...@gmail.com> Looks good to me - there's little reason for using a custom GraphicsConsoleDxe now (historically, the screenshot facility lived there, there's a private interface there for messing with terminal scrolling (unused) and I moved to a different font with my box drawing chars, but the font issue can/needs to be tackled in a different way that Tiano already supports).
A ________________________________ From: Samer El-Haj-Mahmoud <sa...@elhajmahmoud.com> Sent: Tuesday, April 14, 2020 10:43 AM To: devel@edk2.groups.io <devel@edk2.groups.io> Cc: Leif Lindholm <l...@nuviainc.com>; Ard Biesheuvel <ard.biesheu...@arm.com>; Pete Batard <p...@akeo.ie>; Andrei Warkentin <awarken...@vmware.com> Subject: [edk2-platform][PATCH v2 0/3] Platform/RaspberryPi : Switch to common GraphicsConsoleDxe Switch RaspberryPi from using a private GraphicsConsoleDxe to the common GraphicsConsoleDxe in MdeModulePkg. Code pushed to https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsamerhaj%2Fedk2-platforms%2Ftree%2Frpi_switch_graphicsconsole_v2&data=02%7C01%7Cawarkentin%40vmware.com%7C8f89ce43af3343c323e508d7e08aa7e2%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C1%7C637224758448208191&sdata=1%2BAuUTypo9r95E0zrVTEhc7NIQADBd0x8iWCH4OdM%2FQ%3D&reserved=0 version 1: https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F57256&data=02%7C01%7Cawarkentin%40vmware.com%7C8f89ce43af3343c323e508d7e08aa7e2%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C1%7C637224758448208191&sdata=wGKJZNRhtcnU6UVJHTwsM92sTrPtFqzPh0likpNpC%2Bc%3D&reserved=0 version 2 changes: - Set PcdUgaConsumeSupport to FALSE [Ard] Cc: Leif Lindholm <l...@nuviainc.com> Cc: Ard Biesheuvel <ard.biesheu...@arm.com> Cc: Pete Batard <p...@akeo.ie> Cc: Andrei Warkentin <awarken...@vmware.com> Samer El-Haj-Mahmoud (3): Platform/RaspberryPi/RPi4: Switch to common GraphicsConsoleDxe Platform/RaspberryPi/RPi3: Switch to common GraphicsConsoleDxe Platform/RaspberryPi:Remove RPi GraphicsConsoleDxe Platform/RaspberryPi/RPi3/RPi3.dsc | 3 +- Platform/RaspberryPi/RPi4/RPi4.dsc | 3 +- Platform/RaspberryPi/RPi3/RPi3.fdf | 2 +- Platform/RaspberryPi/RPi4/RPi4.fdf | 2 +- .../GraphicsConsoleDxe/GraphicsConsoleDxe.inf | 68 - .../GraphicsConsoleDxe/GraphicsConsole.h | 585 ------ .../GraphicsConsoleDxe/ComponentName.c | 177 -- .../GraphicsConsoleDxe/GraphicsConsole.c | 1831 ----------------- .../Drivers/GraphicsConsoleDxe/NewFont.c | 281 --- .../GraphicsConsoleDxe/GraphicsConsoleDxe.uni | 12 - .../GraphicsConsoleDxeExtra.uni | 12 - 11 files changed, 6 insertions(+), 2970 deletions(-) delete mode 100644 Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/GraphicsConsoleDxe.inf delete mode 100644 Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/GraphicsConsole.h delete mode 100644 Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/ComponentName.c delete mode 100644 Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/GraphicsConsole.c delete mode 100644 Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/NewFont.c delete mode 100644 Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/GraphicsConsoleDxe.uni delete mode 100644 Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/GraphicsConsoleDxeExtra.uni -- 2.17.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#57356): https://edk2.groups.io/g/devel/message/57356 Mute This Topic: https://groups.io/mt/73012847/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
