On 04/17/20 17:59, Ard Biesheuvel wrote: > On 4/17/20 5:37 PM, Laszlo Ersek wrote: >> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2675 >> Repo: https://pagure.io/lersek/edk2.git >> Branch: rsl_cleanup >> >> Rebecca's >> >> [PATCH 02/13] OvmfPkg: support powering off bhyve guests >> >> at >> >> https://edk2.groups.io/g/devel/message/57450 >> >> e4e9b29189b83076e1d1a0b9c989938f5226cab6.1586991816.git.rebecca@bsdio.com">http://mid.mail-archive.com/e4e9b29189b83076e1d1a0b9c989938f5226cab6.1586991816.git.rebecca@bsdio.com >> >> >> made me realize OvmfPkg/ResetSystemLib should be refreshed. This will >> let us add a simple bhyve-specific instance (later), and also allows us >> to fix a long time dormant bug (now). >> >> Cc: Anthony Perard <anthony.per...@citrix.com> >> Cc: Ard Biesheuvel <ard.biesheu...@arm.com> >> Cc: Jordan Justen <jordan.l.jus...@intel.com> >> Cc: Julien Grall <jul...@xen.org> >> Cc: Philippe Mathieu-Daudé <phi...@redhat.com> >> Cc: Rebecca Cran <rebe...@bsdio.com> >> >> Thanks, >> Laszlo >> >> Laszlo Ersek (6): >> OvmfPkg/ResetSystemLib: wrap long lines >> OvmfPkg/ResetSystemLib: clean up library dependencies >> OvmfPkg/ResetSystemLib: improve coding style in ResetSystem() >> OvmfPkg/ResetSystemLib: factor out ResetShutdown() >> OvmfPkg/ResetSystemLib: rename to BaseResetSystemLib >> OvmfPkg/ResetSystemLib: introduce the DxeResetSystemLib instance >> > > For the series, > > Reviewed-by: Ard Biesheuvel <ard.biesheu...@arm.com> > > One nit: putting a diff block inside the commit log [6/6] doesn't help > legibility a lot, and the issue of not being able to access memory that > is not mapped for runtime is so basic that it doesn't require that level > of detail to describe a reproducer and the Linux kernel log output when > the issue is triggered.
Thanks! I will remove the third note altogether (the one that starts with "The bug is not easy to trigger in common setups..."). Thanks! Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#57606): https://edk2.groups.io/g/devel/message/57606 Mute This Topic: https://groups.io/mt/73085501/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
