Dandan, On 04/18/20 17:14, Samer El-Haj-Mahmoud wrote: > Jian, Hao, > > Can you please push this simple patch? It has been reviewed a while ago and > ready to be committed.
should we consider your R-b on the first patch sufficient for pushing? You are marked as "R" for "MdeModulePkg: ACPI modules", but technically speaking, "MdeModulePkg.dec" needs an ACK from either Jian or Hao. Content-wise, your approval looks sufficient, but I don't want to assume. Please confirm. Thank Laszlo >> -----Original Message----- >> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Samer El- >> Haj-Mahmoud via groups.io >> Sent: Friday, April 10, 2020 11:29 AM >> To: devel@edk2.groups.io >> Cc: Dandan Bi <dandan...@intel.com>; Liming Gao <liming....@intel.com>; >> Jian J Wang <jian.j.w...@intel.com>; Hao A Wu <hao.a...@intel.com>; Leif >> Lindholm <l...@nuviainc.com>; Ard Biesheuvel <ard.biesheu...@arm.com> >> Subject: [edk2-devel] [edk2][PATCH v2 1/2] MdeModulePkg: >> PcdAcpiExposedTableVersions default for Arm64 platforms >> >> Set the default value of PcdAcpiExposedTableVersions for Aarch64 platforms to >> 0x20. Previously, the default was set to 0x3E for all platforms. The new >> value >> removes ACPI 1.0b compatability, which forces the use of XSDT 64-bit pointer, >> as required by Arm SBBR specification. >> This also resolves an error reported by acpiview command, as seen on the RPi >> (see https://github.com/pftf/RPi4/issues/25). >> >> Cc: Dandan Bi <dandan...@intel.com> >> Cc: Liming Gao <liming....@intel.com> >> Cc: Jian J Wang <jian.j.w...@intel.com> >> Cc: Hao A Wu <hao.a...@intel.com> >> Cc: Leif Lindholm <l...@nuviainc.com> >> Cc: Ard Biesheuvel <ard.biesheu...@arm.com> >> >> Signed-off-by: Samer El-Haj-Mahmoud <sa...@elhajmahmoud.com> >> Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org> >> Reviewed-by: Dandan Bi <dandan...@intel.com> >> --- >> MdeModulePkg/MdeModulePkg.dec | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/MdeModulePkg/MdeModulePkg.dec >> b/MdeModulePkg/MdeModulePkg.dec index 497574cb0870..fac16f262cf8 >> 100644 >> --- a/MdeModulePkg/MdeModulePkg.dec >> +++ b/MdeModulePkg/MdeModulePkg.dec >> @@ -1548,6 +1548,9 @@ >> # @Prompt Console Output Row of Text Setup >> >> gEfiMdeModulePkgTokenSpaceGuid.PcdSetupConOutRow|25|UINT32|0x40000 >> 00e >> >> +[PcdsFixedAtBuild.AARCH64, PcdsPatchableInModule.AARCH64] >> + >> +gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20|UINT >> 32| >> +0x0001004c >> + >> [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] >> ## UART clock frequency is for the baud rate configuration. >> # @Prompt Serial Port Clock Rate. >> -- >> 2.17.1 >> >> >> > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#57626): https://edk2.groups.io/g/devel/message/57626 Mute This Topic: https://groups.io/mt/72923682/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-