On 04/22/20 13:47, Ni, Ray wrote:
> Eric,
> It's natural to use the volatile registers value derived from BSP in 
> ApInitReconfig path.
> So I still prefer to use the code I suggested in the review comment to the v1 
> patch.
> 
> We can remove the below line that specially for ApInitReconfig path in 
> MpInitLbInitialize().
> https://github.com/tianocore/edk2/blob/master/UefiCpuPkg/Library/MpInitLib/MpLib.c#L1783:
>       CopyMem (&CpuMpData->CpuData[Index].VolatileRegisters, 
> &VolatileRegisters, sizeof (CPU_VOLATILE_REGISTERS));

Sorry I didn't mean to disagree or disregard this feedback.

Laszlo


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#58072): https://edk2.groups.io/g/devel/message/58072
Mute This Topic: https://groups.io/mt/73191434/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to