> -----Original Message----- > From: Wang, Jian J <jian.j.w...@intel.com> > Sent: Wednesday, May 13, 2020 9:49 PM > To: Gao, Zhichao <zhichao....@intel.com>; devel@edk2.groups.io; Fu, Siyuan > <siyuan...@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com>; Yao, > Jiewen <jiewen....@intel.com>; Philippe Mathieu-Daude <phi...@redhat.com>; > Lu, XiaoyuX <xiaoyux...@intel.com> > Subject: RE: [PATCH V4 00/11] CryptoPkg: Retire the deprecated functions > > Zhichao, > > Two general comments for improvement needed in your future patches: > 1. Add r-b for those patch files which have got r-b 2. It'd be better to add > summary of changes between this and previous version > of patches
1. I change the typo of the function definition. So all the patches are changed. That is why I didn't keep any R-B 2. I put the summary change in cover-letter. Thanks for the suggestion. I would put the changes for every patch but not put them in the commit message. > > For v4, > patch 8: the updates of OpensslLib should be done by process_files.pl I didn't find the config string to disable the AES ECB mode only. Can you help guide me on this? Or should I remove the change of OpensslLib in patch #8? Thanks, Zhichao > > With this addressed (for the whole patch series), > > Reviewed-by: Jian J Wang <jian.j.w...@intel.com> > > > Mike, Jiewen, Siyuan, Philippe: any more comments for v4? > > Regards, > Jian > > > -----Original Message----- > > From: Gao, Zhichao <zhichao....@intel.com> > > Sent: Tuesday, May 12, 2020 2:27 AM > > To: devel@edk2.groups.io > > Cc: Wang, Jian J <jian.j.w...@intel.com>; Lu, XiaoyuX > > <xiaoyux...@intel.com>; Fu, Siyuan <siyuan...@intel.com>; Kinney, > > Michael D <michael.d.kin...@intel.com>; Yao, Jiewen > > <jiewen....@intel.com>; Philippe Mathieu-Daude <phi...@redhat.com> > > Subject: [PATCH V4 00/11] CryptoPkg: Retire the deprecated functions > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898 > > > > Retire below deprecated functions: > > MD4, ARC4, TDES, AES ECB MODE, HMAC MD5, HMAC SHA1. > > > > V2: > > Seprate the MD5 and SHA1 changes to other patch set. > > Change the deprecated function wrapper implementatuion in > > EDKII_CRYPTO_PROTOCOL to call a dummy function to print debug message > > and assert. > > > > V3: > > Remove the missing part of deprecated functions in V2. > > Change the name field in the EDKII_CRYPTO_PROTOCOL to indicate the > > function is deprecated and unsupported. > > > > V4: > > Fixed some typos. > > Separate the change of OpensslLib and make the change with > > process_files.pl. > > Moving the incorrect changes of AES_ECB from HAMC MD5 patch to Aes Ecb > > one. > > > > Cc: Jian J Wang <jian.j.w...@intel.com> > > Cc: Xiaoyu Lu <xiaoyux...@intel.com> > > Cc: Siyuan Fu <siyuan...@intel.com> > > Cc: Michael D Kinney <michael.d.kin...@intel.com> > > Cc: Jiewen Yao <jiewen....@intel.com> > > Cc: Philippe Mathieu-Daude <phi...@redhat.com> > > Signed-off-by: Zhichao Gao <zhichao....@intel.com> > > > > Zhichao Gao (8): > > CryptoPkg/CryptoDxe: Add function to indicate the deprecated algorithm > > CryptoPkg/BaseCrpytLib: Retire MD4 algorithm > > CryptoPkg/BaseCryptLib: Retire ARC4 algorithm > > CryptoPkg/BaseCryptLib: Retire the Tdes algorithm > > CryptoPkg/BaseCryptLib: Retire Aes Ecb mode algorithm > > CryptoPkg/BaseCryptLib: Retire HMAC MD5 algorithm > > CryptoPkg/BaseCryptLib: Retire HMAC SHA1 algorithm > > CryptoPkg/Crypto.h: Update the version of Crypto Driver > > > > Zhiguang Liu (3): > > CryptoPkg/OpensslLib: Set MD4 disable in OpensslLib > > CryptoPkg/OpensslLib: Set ARC4 disable in OpensslLib > > CryptoPkg/OpensslLib: Set TDES disable in OpensslLib > > > > CryptoPkg/CryptoPkg.dsc | 46 +- > > CryptoPkg/Driver/Crypto.c | 786 ++--------- > > CryptoPkg/Include/Library/BaseCryptLib.h | 809 ------------ > > .../Library/BaseCryptLib/BaseCryptLib.inf | 7 +- > > .../Library/BaseCryptLib/Cipher/CryptAes.c | 114 -- > > .../BaseCryptLib/Cipher/CryptAesNull.c | 52 - > > .../Library/BaseCryptLib/Cipher/CryptArc4.c | 205 --- > > .../BaseCryptLib/Cipher/CryptArc4Null.c | 124 -- > > .../Library/BaseCryptLib/Cipher/CryptTdes.c | 364 ------ > > .../BaseCryptLib/Cipher/CryptTdesNull.c | 160 --- > > .../Library/BaseCryptLib/Hash/CryptMd4.c | 223 ---- > > .../Library/BaseCryptLib/Hash/CryptMd4Null.c | 143 -- > > .../Library/BaseCryptLib/Hmac/CryptHmacMd5.c | 216 --- > > .../BaseCryptLib/Hmac/CryptHmacMd5Null.c | 139 -- > > .../Library/BaseCryptLib/Hmac/CryptHmacSha1.c | 216 --- > > .../BaseCryptLib/Hmac/CryptHmacSha1Null.c | 139 -- > > .../Library/BaseCryptLib/PeiCryptLib.inf | 11 +- > > .../Library/BaseCryptLib/PeiCryptLib.uni | 8 +- > > CryptoPkg/Library/BaseCryptLib/Pem/CryptPem.c | 7 +- > > .../Library/BaseCryptLib/RuntimeCryptLib.inf | 11 +- > > .../Library/BaseCryptLib/RuntimeCryptLib.uni | 8 +- > > .../Library/BaseCryptLib/SmmCryptLib.inf | 12 +- > > .../Library/BaseCryptLib/SmmCryptLib.uni | 8 +- > > .../BaseCryptLibNull/BaseCryptLibNull.inf | 5 - > > .../BaseCryptLibNull/Cipher/CryptAesNull.c | 52 - > > .../BaseCryptLibNull/Cipher/CryptArc4Null.c | 124 -- > > .../BaseCryptLibNull/Cipher/CryptTdesNull.c | 160 --- > > .../BaseCryptLibNull/Hash/CryptMd4Null.c | 143 -- > > .../BaseCryptLibNull/Hmac/CryptHmacMd5Null.c | 139 -- > > .../BaseCryptLibNull/Hmac/CryptHmacSha1Null.c | 139 -- > > .../BaseCryptLibOnProtocolPpi/CryptLib.c | 1157 ++--------------- > > .../Library/Include/openssl/opensslconf.h | 9 + > > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 28 - > > .../Library/OpensslLib/OpensslLibCrypto.inf | 28 - > > CryptoPkg/Library/OpensslLib/process_files.pl | 3 + > > CryptoPkg/Private/Protocol/Crypto.h | 709 ++-------- > > 36 files changed, 402 insertions(+), 6102 deletions(-) delete mode > > 100644 CryptoPkg/Library/BaseCryptLib/Cipher/CryptArc4.c > > delete mode 100644 > > CryptoPkg/Library/BaseCryptLib/Cipher/CryptArc4Null.c > > delete mode 100644 CryptoPkg/Library/BaseCryptLib/Cipher/CryptTdes.c > > delete mode 100644 > > CryptoPkg/Library/BaseCryptLib/Cipher/CryptTdesNull.c > > delete mode 100644 CryptoPkg/Library/BaseCryptLib/Hash/CryptMd4.c > > delete mode 100644 CryptoPkg/Library/BaseCryptLib/Hash/CryptMd4Null.c > > delete mode 100644 CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacMd5.c > > delete mode 100644 > > CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacMd5Null.c > > delete mode 100644 > > CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha1.c > > delete mode 100644 > > CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha1Null.c > > delete mode 100644 > > CryptoPkg/Library/BaseCryptLibNull/Cipher/CryptArc4Null.c > > delete mode 100644 > > CryptoPkg/Library/BaseCryptLibNull/Cipher/CryptTdesNull.c > > delete mode 100644 > > CryptoPkg/Library/BaseCryptLibNull/Hash/CryptMd4Null.c > > delete mode 100644 > > CryptoPkg/Library/BaseCryptLibNull/Hmac/CryptHmacMd5Null.c > > delete mode 100644 > > CryptoPkg/Library/BaseCryptLibNull/Hmac/CryptHmacSha1Null.c > > > > -- > > 2.21.0.windows.1 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#59481): https://edk2.groups.io/g/devel/message/59481 Mute This Topic: https://groups.io/mt/74142368/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
