Thanks Eric!! > -----Original Message----- > From: Dong, Eric <eric.d...@intel.com> > Sent: Thursday, May 14, 2020 6:54 AM > To: devel@edk2.groups.io; Chaganty, Rangasai V > <rangasai.v.chaga...@intel.com>; Esakkithevar, Kathappan > <kathappan.esakkithe...@intel.com> > Cc: Chiu, Chasel <chasel.c...@intel.com>; Desimone, Nathaniel L > <nathaniel.l.desim...@intel.com>; Kethi Reddy, Deepika > <deepika.kethi.re...@intel.com> > Subject: RE: [edk2-devel] [Patch V1 1/1] CometlakeOpenBoardPkg: Fix build > error due to Ddr4MixedUDimm2DpcLimit > > Hi all, > > Seems this patch has passed code review. > Also, it used to fix a platform build failure, and other patches will be > blocked > if this platform build failure, so I help to push the code change. > > Pushed: SHA-1: c2cb5a4d1b54e8fe79fe1c1132034989597fee10 > > > Thanks, > Eric > > > -----Original Message----- > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of > > Chaganty, Rangasai V > > Sent: Wednesday, May 13, 2020 8:11 AM > > To: Esakkithevar, Kathappan <kathappan.esakkithe...@intel.com>; > > devel@edk2.groups.io > > Cc: Chiu, Chasel <chasel.c...@intel.com>; Desimone, Nathaniel L > > <nathaniel.l.desim...@intel.com>; Kethi Reddy, Deepika > > <deepika.kethi.re...@intel.com> > > Subject: Re: [edk2-devel] [Patch V1 1/1] CometlakeOpenBoardPkg: Fix > > build error due to Ddr4MixedUDimm2DpcLimit > > > > Reviewed-by: Sai Chaganty <rangasai.v.chaga...@intel.com> > > > > -----Original Message----- > > From: Esakkithevar, Kathappan <kathappan.esakkithe...@intel.com> > > Sent: Tuesday, May 12, 2020 10:26 AM > > To: devel@edk2.groups.io > > Cc: Chaganty, Rangasai V <rangasai.v.chaga...@intel.com>; Chiu, Chasel > > <chasel.c...@intel.com>; Desimone, Nathaniel L > > <nathaniel.l.desim...@intel.com>; Kethi Reddy, Deepika > > <deepika.kethi.re...@intel.com> > > Subject: [Patch V1 1/1] CometlakeOpenBoardPkg: Fix build error due to > > Ddr4MixedUDimm2DpcLimit > > > > The Ddr4MixedUDimm2DpcLimit FSP-M Upd has been renamed as > > Ddr4Mixed2DpcLimit at CometLakeFspBinPkg\CometLake1. > > FSP wrapper driver need to use FSP-M Upd name Ddr4Mixed2DpcLimit > from > > CometLake1 FSP at CometlakeOpenBoardPkg. > > > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2714 > > > > Signed-off-by: Kathappan Esakkithevar > > <kathappan.esakkithe...@intel.com> > > Cc: Sai Chaganty <rangasai.v.chaga...@intel.com> > > Cc: Chasel Chiu <chasel.c...@intel.com> > > Cc: Nate DeSimone <nathaniel.l.desim...@intel.com> > > Cc: Deepika Kethi Reddy <deepika.kethi.re...@intel.com> > > --- > > .../FspWrapper/Library/PeiFspPolicyInitLib/PeiFspSaPolicyInitLib.c | > > 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git > > > a/Platform/Intel/CometlakeOpenBoardPkg/FspWrapper/Library/PeiFspPolic > > yInitLib/PeiFspSaPolicyInitLib.c > > > b/Platform/Intel/CometlakeOpenBoardPkg/FspWrapper/Library/PeiFspPolic > > yInitLib/PeiFspSaPolicyInitLib.c > > index 45d76ad5e4..53f26d824f 100644 > > --- > > > a/Platform/Intel/CometlakeOpenBoardPkg/FspWrapper/Library/PeiFspPolic > > yInitLib/PeiFspSaPolicyInitLib.c > > +++ > > b/Platform/Intel/CometlakeOpenBoardPkg/FspWrapper/Library/PeiFspPoli > > +++ cyInitLib/PeiFspSaPolicyInitLib.c > > @@ -344,7 +344,7 @@ PeiFspSaPolicyInitPreMem ( > > FspmUpd->FspmConfig.GdxcIotSize = MemConfig->GdxcIotSize; > > FspmUpd->FspmConfig.GdxcMotSize = MemConfig->GdxcMotSize; > > FspmUpd->FspmConfig.DualDimmPerChannelBoardType =(UINT8) > > MemConfig->DualDimmPerChannelBoardType; > > - FspmUpd->FspmConfig.Ddr4MixedUDimm2DpcLimit =(UINT8) > > MemConfig->Ddr4MixedUDimm2DpcLimit; > > + FspmUpd->FspmConfig.Ddr4Mixed2DpcLimit =(UINT8) MemConfig- > > >Ddr4MixedUDimm2DpcLimit; > > // > > // Update UPD:CaVrefConfig > > // > > -- > > 2.16.2.windows.1 > > > > > > >
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#59484): https://edk2.groups.io/g/devel/message/59484 Mute This Topic: https://groups.io/mt/74163837/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
