On 05/19/20 23:50, Lendacky, Thomas wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198
> 
> Under SEV-ES, a INVD intercept generates a #VC exception. VMGEXIT must be
> used to allow the hypervisor to handle this intercept.
> 
> Cc: Jordan Justen <jordan.l.jus...@intel.com>
> Cc: Laszlo Ersek <ler...@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheu...@arm.com>
> Signed-off-by: Tom Lendacky <thomas.lenda...@amd.com>
> ---
>  .../Library/VmgExitLib/X64/VmgExitVcHandler.c | 36 +++++++++++++++++++
>  1 file changed, 36 insertions(+)
> 
> diff --git a/OvmfPkg/Library/VmgExitLib/X64/VmgExitVcHandler.c 
> b/OvmfPkg/Library/VmgExitLib/X64/VmgExitVcHandler.c
> index d6b35b3019c3..0b7f24fd962c 100644
> --- a/OvmfPkg/Library/VmgExitLib/X64/VmgExitVcHandler.c
> +++ b/OvmfPkg/Library/VmgExitLib/X64/VmgExitVcHandler.c
> @@ -1162,6 +1162,38 @@ IoioExit (
>    return 0;
>  }
>  
> +/**
> +  Handle a INVD event.
> +
> +  Use the VMGEXIT instruction to handle a INVD event.
> +
> +  @param[in, out] Ghcb             Pointer to the Guest-Hypervisor 
> Communication
> +                                   Block
> +  @param[in, out] Regs             x64 processor context
> +  @param[in]      InstructionData  Instruction parsing context
> +
> +  @retval 0                        Event handled successfully
> +  @retval Others                   New exception value to propagate
> +
> +**/
> +STATIC
> +UINT64
> +InvdExit (
> +  IN OUT GHCB                     *Ghcb,
> +  IN OUT EFI_SYSTEM_CONTEXT_X64   *Regs,
> +  IN     SEV_ES_INSTRUCTION_DATA  *InstructionData
> +  )
> +{
> +  UINT64  Status;
> +
> +  Status = VmgExit (Ghcb, SVM_EXIT_INVD, 0, 0);
> +  if (Status) {
> +    return Status;
> +  }
> +
> +  return 0;
> +}

(1) Please see my feedback under:

  [PATCH v8 18/46] OvmfPkg/VmgExitLib: Add support for WBINVD NAE events

and pick the same approach here that you prefer there.

With that:

Acked-by: Laszlo Ersek <ler...@redhat.com>

Thanks
Laszlo

> +
>  /**
>    Handle a CPUID event.
>  
> @@ -1351,6 +1383,10 @@ VmgExitHandleVc (
>      NaeExit = CpuidExit;
>      break;
>  
> +  case SVM_EXIT_INVD:
> +    NaeExit = InvdExit;
> +    break;
> +
>    case SVM_EXIT_IOIO_PROT:
>      NaeExit = IoioExit;
>      break;
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#60149): https://edk2.groups.io/g/devel/message/60149
Mute This Topic: https://groups.io/mt/74336576/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to