On Fri, May 29, 2020 at 05:21:24 +0000, Pankaj Bansal (OSS) wrote:
> > > ---
> > a/Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf
> > > +++
> > b/Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf
> > > @@ -19,9 +19,12 @@
> > > ArmPkg/ArmPkg.dec
> > > ArmPlatformPkg/ArmPlatformPkg.dec
> > > Silicon/NXP/NxpQoriqLs.dec
> > > + Silicon/NXP/Chassis3V2/Chassis3V2.dec
> > > + Silicon/NXP/LX2160A/LX2160A.dec
> >
> > Please insert alphabetically sorted.
>
> I intentionally kept these in this order. because Soc depends on Chassis for
> any include files
> Chassis depends on NxpQoriqLs.dec for any include files.
OK, I see the logic behind that, but as it has no functional meaning I
don't think it outweighs the benefit of alphabetical sorting.
I *do* tend to say "alphabetically, unless there is a better logical
order", but by that I usually mean grouping related Pcd dependency
declarations.
This is my only remaining niggle with this set - are you OK with me
folding in
--- a/Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf
+++ b/Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf
@@ -18,9 +18,9 @@ [Packages]
MdeModulePkg/MdeModulePkg.dec
ArmPkg/ArmPkg.dec
ArmPlatformPkg/ArmPlatformPkg.dec
- Silicon/NXP/NxpQoriqLs.dec
Silicon/NXP/Chassis3V2/Chassis3V2.dec
Silicon/NXP/LX2160A/LX2160A.dec
+ Silicon/NXP/NxpQoriqLs.dec
to v3 9/10 and pushing the set?
/
Leif
> >
> > >
> > > [LibraryClasses]
> > > ArmLib
> > > + SocLib
> > > DebugLib
> >
> > Please insert alphabetically sorted.
>
> This I can take care
>
> >
> > No further comments on this set for v2.
> > For the patches I have not commented on:
> > Reviewed-by: Leif Lindholm <l...@nuviainc.com>
> >
> > /
> > Leif
> >
> > >
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#60449): https://edk2.groups.io/g/devel/message/60449
Mute This Topic: https://groups.io/mt/74496024/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
