Reviewed-by: Dong, Guo <[email protected]>
Thanks, Guo > -----Original Message----- > From: Tan, Ming <[email protected]> > Sent: Tuesday, June 9, 2020 4:24 AM > To: [email protected] > Cc: Ma, Maurice <[email protected]>; Dong, Guo > <[email protected]>; You, Benjamin <[email protected]> > Subject: [PATCH v3 3/4] UefiPayloadPkg/UefiPayloadPkgIa*.dsc: Change > some PCDs type > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2786 > > Since the type of PcdStatusCodeUseSerial and PcdStatusCodeUseMemory > in MdeModulePkg.dec are changed, so change them from > PcdsFeatureFlag to PcdsFixedAtBuild in dsc files. > > Cc: Maurice Ma <[email protected]> > Cc: Guo Dong <[email protected]> > Cc: Benjamin You <[email protected]> > Signed-off-by: Ming Tan <[email protected]> > --- > V3: Split one patch to several patchs, each Pkg has one patch. > > UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 16 +++++++++------- > UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 16 +++++++++------- > 2 files changed, 18 insertions(+), 14 deletions(-) > > diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc > b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc > index d52945442e..b0708cf01f 100644 > --- a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc > +++ b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc > @@ -3,7 +3,7 @@ > # > > # Provides drivers and definitions to create uefi payload for bootloaders. > > # > > -# Copyright (c) 2014 - 2019, Intel Corporation. All rights reserved.<BR> > > +# Copyright (c) 2014 - 2020, Intel Corporation. All rights reserved.<BR> > > # SPDX-License-Identifier: BSD-2-Clause-Patent > > # > > ## > > @@ -264,12 +264,6 @@ > # > > > ########################################################## > ###################### > > [PcdsFeatureFlag] > > -!if $(TARGET) == DEBUG > > - gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE > > -!else > > - gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE > > -!endif > > - gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE > > gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|FALSE > > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE > > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutUgaSupport|FALSE > > @@ -292,6 +286,14 @@ > > gEfiSourceLevelDebugPkgTokenSpaceGuid.PcdDebugLoadImageMethod|0x > 2 > > !endif > > > > + # Status Code support. > > +!if $(TARGET) == DEBUG > > + gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE > > +!else > > + gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE > > +!endif > > + gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE > > + > > [PcdsPatchableInModule.common] > > gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x7 > > gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x8000004F > > diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > index 0736cd9954..3ca0f2fd93 100644 > --- a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > +++ b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc > @@ -3,7 +3,7 @@ > # > > # Provides drivers and definitions to create uefi payload for bootloaders. > > # > > -# Copyright (c) 2014 - 2019, Intel Corporation. All rights reserved.<BR> > > +# Copyright (c) 2014 - 2020, Intel Corporation. All rights reserved.<BR> > > # SPDX-License-Identifier: BSD-2-Clause-Patent > > # > > ## > > @@ -265,12 +265,6 @@ > # > > > ########################################################## > ###################### > > [PcdsFeatureFlag] > > -!if $(TARGET) == DEBUG > > - gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE > > -!else > > - gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE > > -!endif > > - gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE > > gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|TRUE > > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE > > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutUgaSupport|FALSE > > @@ -294,6 +288,14 @@ > > gEfiSourceLevelDebugPkgTokenSpaceGuid.PcdDebugLoadImageMethod|0x > 2 > > !endif > > > > + # Status Code support. > > +!if $(TARGET) == DEBUG > > + gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE > > +!else > > + gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE > > +!endif > > + gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE > > + > > [PcdsPatchableInModule.common] > > gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x7 > > gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x8000004F > > -- > 2.24.0.windows.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#60981): https://edk2.groups.io/g/devel/message/60981 Mute This Topic: https://groups.io/mt/74771801/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
