All public APIs should have EFIAPI modifier. Somehow PciSegmentInfoLib missed the EFIAPI modifier. The patch updates the library header file and NULL instance in MdePkg to add the missing EFIAPI.
Signed-off-by: Ray Ni <[email protected]> Cc: Michael D Kinney <[email protected]> Cc: Liming Gao <[email protected]> Cc: Zhiguang Liu <[email protected]> --- MdePkg/Include/Library/PciSegmentInfoLib.h | 3 ++- MdePkg/Library/BasePciSegmentInfoLibNull/PciSegmentInfoLib.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/MdePkg/Include/Library/PciSegmentInfoLib.h b/MdePkg/Include/Library/PciSegmentInfoLib.h index 320a223628..659ff85649 100644 --- a/MdePkg/Include/Library/PciSegmentInfoLib.h +++ b/MdePkg/Include/Library/PciSegmentInfoLib.h @@ -3,7 +3,7 @@ This library is consumed by PciSegmentLib to support multiple segment PCI configuration access. - Copyright (c) 2017, Intel Corporation. All rights reserved.<BR> + Copyright (c) 2017 - 2020, Intel Corporation. All rights reserved.<BR> SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -28,6 +28,7 @@ typedef struct { @retval A callee owned array holding the segment information. **/ PCI_SEGMENT_INFO * +EFIAPI GetPciSegmentInfo ( UINTN *Count ); diff --git a/MdePkg/Library/BasePciSegmentInfoLibNull/PciSegmentInfoLib.c b/MdePkg/Library/BasePciSegmentInfoLibNull/PciSegmentInfoLib.c index f9019c4e64..3ec7784057 100644 --- a/MdePkg/Library/BasePciSegmentInfoLibNull/PciSegmentInfoLib.c +++ b/MdePkg/Library/BasePciSegmentInfoLibNull/PciSegmentInfoLib.c @@ -2,7 +2,7 @@ Default PCI Segment Information Library that returns one segment whose segment base address equals to PcdPciExpressBaseAddress. - Copyright (c) 2017, Intel Corporation. All rights reserved.<BR> + Copyright (c) 2017 - 2020, Intel Corporation. All rights reserved.<BR> SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -21,6 +21,7 @@ @retval A callee owned array holding the segment information. **/ PCI_SEGMENT_INFO * +EFIAPI GetPciSegmentInfo ( UINTN *Count ) -- 2.26.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#61393): https://edk2.groups.io/g/devel/message/61393 Mute This Topic: https://groups.io/mt/74933721/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
