PR: https://github.com/tianocore/edk2/pull/713
> -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Liming Gao > Sent: Friday, June 19, 2020 5:12 PM > To: Philippe Mathieu-Daudé <phi...@redhat.com>; Wasim Khan > <wasim.k...@nxp.com>; devel@edk2.groups.io > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Varun Sethi > <v.se...@nxp.com> > Subject: Re: [edk2-devel] [PATCH v2] MdePkg: Include Acpi header file > > Reviewed-by: Liming Gao <liming....@intel.com> > > -----Original Message----- > From: Philippe Mathieu-Daudé <phi...@redhat.com> > Sent: 2020年6月1日 19:18 > To: Wasim Khan <wasim.k...@nxp.com>; devel@edk2.groups.io > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Gao, Liming > <liming....@intel.com>; Varun Sethi <v.se...@nxp.com> > Subject: Re: [edk2-devel] [PATCH v2] MdePkg: Include Acpi header file > > On 6/1/20 1:16 PM, Wasim Khan wrote: > > > > > >> -----Original Message----- > >> From: Philippe Mathieu-Daudé <phi...@redhat.com> > >> Sent: Monday, June 1, 2020 2:17 PM > >> To: devel@edk2.groups.io; Wasim Khan <wasim.k...@nxp.com> > >> Cc: michael.d.kin...@intel.com; liming....@intel.com; Varun Sethi > >> <v.se...@nxp.com> > >> Subject: Re: [edk2-devel] [PATCH v2] MdePkg: Include Acpi header file > >> > >> On 4/20/20 9:48 AM, Wasim Khan wrote: > >>> ACPI memory mapped configuration space access (MCFG) table requires > >>> defination of EFI_ACPI_DESCRIPTION_HEADER. > >> > >> What about: > >> > >> - DynamicTablesPkg/Include/Library/TableHelperLib.h > >> - DynamicTablesPkg/Include/StandardNameSpaceObjects.h > >> - EmbeddedPkg/Include/Library/AcpiLib.h > > > > EmbeddedPkg/Include/Library/AcpiLib.h => Acpi10.h is included in this file. > > For other two, Acpi.h /Acpi10.h has been included in the files where above > > header file are used. > > OK, thanks Wasim. > > Reviewed-by: Philippe Mathieu-Daude <phi...@redhat.com> > > > > >> > >>> > >>> Signed-off-by: Wasim Khan <wasim.k...@nxp.com> > >>> --- > >>> Changes in v2: Corrected typo in subject > >>> > >>> .../IndustryStandard/MemoryMappedConfigurationSpaceAccessTable.h | > >> 2 ++ > >>> 1 file changed, 2 insertions(+) > >>> > >>> diff --git > >>> > >> a/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAcces > >> s > >>> Table.h > >>> > >> b/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAcces > >> s > >>> Table.h > >>> index 3356ec9..8a4933d 100644 > >>> --- > >>> > >> a/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAcces > >> s > >>> Table.h > >>> +++ > >> b/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAc > >>> +++ cessTable.h > >>> @@ -10,6 +10,8 @@ > >>> #ifndef _MEMORY_MAPPED_CONFIGURATION_SPACE_ACCESS_TABLE_H_ > >>> #define _MEMORY_MAPPED_CONFIGURATION_SPACE_ACCESS_TABLE_H_ > >>> > >>> +#include <IndustryStandard/Acpi.h> > >>> + > >>> // > >>> // Ensure proper structure formats > >>> // > >>> > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#61519): https://edk2.groups.io/g/devel/message/61519 Mute This Topic: https://groups.io/mt/73144786/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-