Hi Qi We should not add this attribute to TCG2_PROTOCOL, which is defined by TCG. This attribute should be only applied to TCG_PPI. Please move it there.
> -----Original Message----- > From: Zhang, Qi1 <qi1.zh...@intel.com> > Sent: Thursday, July 16, 2020 3:44 PM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 <qi1.zh...@intel.com>; Kinney, Michael D > <michael.d.kin...@intel.com>; Gao, Liming <liming....@intel.com>; Yao, > Jiewen <jiewen....@intel.com> > Subject: [PATCH v2 7/7] MdePkg/Tcg2Protocol: define Flag > EFI_TCG2_PRE_HASH > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2841 > > Cc: Michael D Kinney <michael.d.kin...@intel.com> > Cc: Liming Gao <liming....@intel.com> > Cc: Jiewen Yao <jiewen....@intel.com> > Cc: Qi Zhang <qi1.zh...@intel.com> > Signed-off-by: Qi Zhang <qi1.zh...@intel.com> > --- > MdePkg/Include/Protocol/Tcg2Protocol.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/MdePkg/Include/Protocol/Tcg2Protocol.h > b/MdePkg/Include/Protocol/Tcg2Protocol.h > index 5ef13cc607..4659802251 100644 > --- a/MdePkg/Include/Protocol/Tcg2Protocol.h > +++ b/MdePkg/Include/Protocol/Tcg2Protocol.h > @@ -98,6 +98,10 @@ typedef struct tdEFI_TCG2_BOOT_SERVICE_CAPABILITY { > // > > #define EFI_TCG2_EXTEND_ONLY 0x0000000000000001 > > // > > +// This bit is shall be set when HashData is the pre-hash digest. > > +// > > +#define EFI_TCG2_PRE_HASH 0x0000000000000010 > > +// > > // This bit shall be set when the intent is to measure a PE/COFF image. > > // > > #define PE_COFF_IMAGE 0x0000000000000010 > > -- > 2.26.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#62667): https://edk2.groups.io/g/devel/message/62667 Mute This Topic: https://groups.io/mt/75537326/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-