Reviewed-by: Yuwei Chen<yuwei.c...@intel.com> > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Zhang, > Shenglei > Sent: Thursday, July 16, 2020 11:14 AM > To: devel@edk2.groups.io > Cc: Feng, Bob C <bob.c.f...@intel.com>; Gao, Liming <liming....@intel.com> > Subject: [edk2-devel] [PATCH] BaseTools/PatchCheck.py: Skip length check > for user name in xxx-by > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2836 > Current PatchCheck.py checks each line to ensure line's length is not larger > than 76. But there's a case that length of user's name is much longer than > that number. So enhance the script to handle this case. > > Cc: Bob Feng <bob.c.f...@intel.com> > Cc: Liming Gao <liming....@intel.com> > Signed-off-by: Shenglei Zhang <shenglei.zh...@intel.com> > --- > BaseTools/Scripts/PatchCheck.py | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/BaseTools/Scripts/PatchCheck.py > b/BaseTools/Scripts/PatchCheck.py index 52244b0bc4d8..7db0775d14d1 > 100755 > --- a/BaseTools/Scripts/PatchCheck.py > +++ b/BaseTools/Scripts/PatchCheck.py > @@ -268,7 +268,14 @@ class CommitMessageCheck: > for i in range(2, count): > if (len(lines[i]) >= 76 and > len(lines[i].split()) > 1 and > - not lines[i].startswith('git-svn-id:')): > + not lines[i].startswith('git-svn-id:') and > + not lines[i].startswith('Reviewed-by') and > + not lines[i].startswith('Acked-by:') and > + not lines[i].startswith('Tested-by:') and > + not lines[i].startswith('Reported-by:') and > + not lines[i].startswith('Suggested-by:') and > + not lines[i].startswith('Signed-off-by:') and > + not lines[i].startswith('Cc:')): > # > # Print a warning if body line is longer than 75 characters > # > -- > 2.18.0.windows.1 > > >
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#62672): https://edk2.groups.io/g/devel/message/62672 Mute This Topic: https://groups.io/mt/75535068/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
