Reviewed-by: Bob Feng <[email protected]> -----Original Message----- From: Gao, Liming <[email protected]> Sent: Thursday, August 13, 2020 3:59 PM To: [email protected] Cc: Feng, Bob C <[email protected]>; Chen, Christine <[email protected]> Subject: [Patch] BaseTools: Fix the issue in VS2017/VS2019 setting
edksetup.bat VS2017 should set VS2017 only. But now, it will set VS2017/VS2019 both. This patch corrects it. Signed-off-by: Liming Gao <[email protected]> Cc: Bob Feng <[email protected]> Cc: Yuwei Chen <[email protected]> --- This patch bases on the change https://edk2.groups.io/g/devel/message/64138 BaseTools/set_vsprefix_envs.bat | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/BaseTools/set_vsprefix_envs.bat b/BaseTools/set_vsprefix_envs.bat index 2627587ba3..d4eb84f064 100644 --- a/BaseTools/set_vsprefix_envs.bat +++ b/BaseTools/set_vsprefix_envs.bat @@ -167,6 +167,8 @@ if not defined WINSDK_PATH_FOR_RC_EXE ( ) ) +if /I "%1"=="VS2017" goto SetWinDDK + :SetVS2019 if not defined VS160COMNTOOLS ( @REM clear two envs so that vcvars32.bat can run successfully. @@ -226,6 +228,8 @@ if not defined WINSDK_PATH_FOR_RC_EXE ( ) ) +if /I "%1"=="VS2019" goto SetWinDDK + :SetWinDDK if not defined WINDDK3790_PREFIX ( set WINDDK3790_PREFIX=C:\WINDDK\3790.1830\bin\ -- 2.27.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#64261): https://edk2.groups.io/g/devel/message/64261 Mute This Topic: https://groups.io/mt/76163640/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
