Thanks Ard and Pete. I did use the cover letter, but forgot to add the CC https://edk2.groups.io/g/devel/message/64301
> -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ard > Biesheuvel via groups.io > Sent: Monday, August 17, 2020 9:55 AM > To: Samer El-Haj-Mahmoud <samer.el-haj-mahm...@arm.com>; > devel@edk2.groups.io > Cc: Leif Lindholm <l...@nuviainc.com>; Pete Batard <p...@akeo.ie>; Andrei > Warkentin (awarken...@vmware.com) <awarken...@vmware.com> > Subject: Re: [edk2-devel] [edk2-platform][PATCH v1 1/3] > Platforms/RaspberryPi: Fix DisplayDxe ComponentName2 error checking > > On 8/15/20 10:26 PM, Samer El-Haj-Mahmoud wrote: > > Fix input param error checking for the DisplayDxe ComponentName2 > > protocol. > > > > This fixes https://github.com/pftf/RPi4/issues/84 > > > > Cc: Leif Lindholm <l...@nuviainc.com> > > Cc: Pete Batard <p...@akeo.ie> > > Cc: Andrei Warkentin <awarken...@vmware.com> > > Cc: Ard Biesheuvel <ard.biesheu...@arm.com> > > Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahm...@arm.com> > > --- > > Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.h | 2 ++ > > Platform/RaspberryPi/Drivers/DisplayDxe/ComponentName.c | 22 > ++++++++++++++++++++ > > 2 files changed, 24 insertions(+) > > > > Please use a cover letter for multipatch series. > > Series pushed as c475b1bbda25..69009e5b91a7 (with Pete's comments > addressed) > > Thanks, > > > diff --git a/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.h > > b/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.h > > index bfbe9e868843..073f65111645 100644 > > --- a/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.h > > +++ b/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.h > > @@ -1,5 +1,6 @@ > > /** @file > > * > > + * Copyright (c) 2020, ARM Limited. All rights reserved. > > * Copyright (c) 2017-2018, Andrei Warkentin > <andrey.warken...@gmail.com> > > * Copyright (c) Microsoft Corporation. All rights reserved. > > * > > @@ -27,6 +28,7 @@ > > extern EFI_GRAPHICS_OUTPUT_PROTOCOL gDisplayProto; > > extern EFI_COMPONENT_NAME_PROTOCOL gComponentName; > > extern EFI_COMPONENT_NAME2_PROTOCOL gComponentName2; > > +extern EFI_DRIVER_BINDING_PROTOCOL mDriverBinding; > > > > VOID > > RegisterScreenshotHandlers ( > > diff --git a/Platform/RaspberryPi/Drivers/DisplayDxe/ComponentName.c > > b/Platform/RaspberryPi/Drivers/DisplayDxe/ComponentName.c > > index 092230cd7c9b..4c065b5d51bf 100644 > > --- a/Platform/RaspberryPi/Drivers/DisplayDxe/ComponentName.c > > +++ b/Platform/RaspberryPi/Drivers/DisplayDxe/ComponentName.c > > @@ -1,5 +1,6 @@ > > /** @file > > * > > + * Copyright (c) 2020, ARM Limited. All rights reserved. > > * Copyright (c) 2018, Andrei Warkentin <andrey.warken...@gmail.com> > > * Copyright (c) 2006-2016, Intel Corporation. All rights reserved. > > * > > @@ -206,6 +207,27 @@ ComponentNameGetControllerName ( > > OUT CHAR16 **ControllerName > > ) > > { > > + EFI_STATUS Status; > > + > > + // > > + // This is a device driver, so ChildHandle must be NULL. > > + // > > + if (ChildHandle != NULL) { > > + return EFI_UNSUPPORTED; > > + } > > + > > + // > > + // Make sure this driver is currently managing ControllHandle // > > + Status = EfiTestManagedDevice ( > > + ControllerHandle, > > + mDriverBinding.DriverBindingHandle, > > + &gEfiGraphicsOutputProtocolGuid > > + ); > > + if (EFI_ERROR (Status)) { > > + return Status; > > + } > > + > > return LookupUnicodeString2 ( > > Language, > > This->SupportedLanguages, > > > > > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#64319): https://edk2.groups.io/g/devel/message/64319 Mute This Topic: https://groups.io/mt/76213602/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
