Hi Laszlo, No worries, please let me know if you have any comments/concerns down the road.
Thank you, Vladimir > -----Original Message----- > From: Laszlo Ersek <ler...@redhat.com> > Sent: Wednesday, August 26, 2020 6:56 AM > To: devel@edk2.groups.io; vladimir.olovyanni...@broadcom.com > Cc: Maciej Rabeda <maciej.rab...@linux.intel.com>; Zhichao Gao > <zhichao....@intel.com>; Jiaxin Wu <jiaxin...@intel.com>; Siyuan Fu > <siyuan...@intel.com>; Ray Ni <ray...@intel.com>; Liming Gao > <liming....@intel.com>; Nd <n...@arm.com>; Samer El-Haj-Mahmoud > <samer.el-haj-mahm...@arm.com> > Subject: Re: [edk2-devel] [PATCH v7 0/1] ShellPkg/DynamicCommand: add > HttpDynamicCommand > > Hi Vladimir, > > On 08/25/20 19:20, Vladimir Olovyannikov via groups.io wrote: > > Signed-off-by: Vladimir Olovyannikov > > <vladimir.olovyanni...@broadcom.com> > > Reviewed-by: Maciej Rabeda <maciej.rab...@linux.intel.com> > > Cc: Zhichao Gao <zhichao....@intel.com> > > Cc: Maciej Rabeda <maciej.rab...@linux.intel.com> > > Cc: Jiaxin Wu <jiaxin...@intel.com> > > Cc: Siyuan Fu <siyuan...@intel.com> > > Cc: Ray Ni <ray...@intel.com> > > Cc: Liming Gao <liming....@intel.com> > > Cc: Nd <n...@arm.com> > > Cc: Laszlo Ersek <ler...@redhat.com> > > Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahm...@arm.com> > > > > This patchset introduces an http client utilizing EDK2 HTTP protocol, > > to allow fast image downloading from http/https servers. > > HTTP download speed is usually faster than tftp. > > The client is based on the same approach as tftp dynamic command, and > > uses the same UEFI Shell command line parameters. This makes it easy > > integrating http into existing UEFI Shell scripts. > > Note that to enable HTTP download, feature Pcd > > gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections must be set to > TRUE. > > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2860 > > > > PATCH v7 changes: > > Address Laszlo' and Maciej's comments: > > - Remove openssl submodule change accidentally added to the v6 > patchset; > > - Fix code style issues in the code overlooked in the previous > > patchset. > > I'm currently working on some VCPU hotplug fixes for the upcoming release. > Before I return to your HttpDynamicCommand patch, I'll also have to > re-read > my earlier comments for it. (In fact I can't tell off-hand if I had > remaining > requests for your patch, or not -- hence the need for re-reading my > earlier > comments.) It could take some time -- thanks for your patience. > > Thanks, > Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#64645): https://edk2.groups.io/g/devel/message/64645 Mute This Topic: https://groups.io/mt/76411440/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
