Reviewed-by: Kathappan Esakkithevar <[email protected]>
> -----Original Message----- > From: Chiu, Chasel <[email protected]> > Sent: Wednesday, September 2, 2020 1:29 PM > To: Desimone, Nathaniel L <[email protected]>; > [email protected] > Cc: Chaganty, Rangasai V <[email protected]>; Kethi Reddy, > Deepika <[email protected]>; Esakkithevar, Kathappan > <[email protected]> > Subject: RE: [edk2-platforms] [PATCH V1] CometlakeOpenBoardPkg: Add > usage of CometlakeSiliconBinPkg > > > Reviewed-by: Chasel Chiu <[email protected]> > > > -----Original Message----- > > From: Desimone, Nathaniel L <[email protected]> > > Sent: Wednesday, September 2, 2020 3:15 PM > > To: [email protected] > > Cc: Chiu, Chasel <[email protected]>; Chaganty, Rangasai V > > <[email protected]>; Kethi Reddy, Deepika > > <[email protected]>; Esakkithevar, Kathappan > > <[email protected]> > > Subject: [edk2-platforms] [PATCH V1] CometlakeOpenBoardPkg: Add usage > > of CometlakeSiliconBinPkg > > > > Updates CometlakeOpenBoardPkg to use CometlakeSiliconBinPkg instead > of > > CoffeelakeSiliconBinPkg. > > > > Cc: Chasel Chiu <[email protected]> > > Cc: Rangasai V Chaganty <[email protected]> > > Cc: Deepika Kethi Reddy <[email protected]> > > Cc: Kathappan Esakkithevar <[email protected]> > > Signed-off-by: Nate DeSimone <[email protected]> > > --- > > .../CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc | 5 > > +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git > > > a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg. > d > > sc > > > b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg. > d > > sc > > index 2d9dcb139f..6de834565a 100644 > > --- > > > a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg. > d > > sc > > +++ > > > b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg. > d > > s > > +++ c > > @@ -10,7 +10,7 @@ > > [Defines] > > DEFINE PLATFORM_PACKAGE = MinPlatformPkg > > DEFINE PLATFORM_SI_PACKAGE = CoffeelakeSiliconPkg > > - DEFINE PLATFORM_SI_BIN_PACKAGE = CoffeelakeSiliconBinPkg > > + DEFINE PLATFORM_SI_BIN_PACKAGE = CometlakeSiliconBinPkg > > DEFINE PLATFORM_FSP_BIN_PACKAGE = > > CometLakeFspBinPkg/CometLake1 > > DEFINE PLATFORM_BOARD_PACKAGE = > > CometlakeOpenBoardPkg > > DEFINE BOARD = CometlakeURvp > > @@ -39,7 +39,8 @@ > > # > > # Include PCD configuration for this board. > > # > > - !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc > > > > + !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc > > + > > !include OpenBoardPkgPcd.dsc > > !include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc > > > > -- > > 2.27.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#64969): https://edk2.groups.io/g/devel/message/64969 Mute This Topic: https://groups.io/mt/76577729/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
