[AMD Public Use] Hi Lazlo,
Thanks for the feedback. Noted, I'll spell it out in the future. 'Last initial' was habit from a team I used to work with. Thanks, Paul -----Original Message----- From: Laszlo Ersek <ler...@redhat.com> Sent: Wednesday, September 2, 2020 1:58 AM To: devel@edk2.groups.io; Grimes, Paul <paul.gri...@amd.com> Cc: Michael D Kinney <michael.d.kin...@intel.com>; Liming Gao <gaolim...@byosoft.com.cn>; Zhiguang Liu <zhiguang....@intel.com> Subject: Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Correcting EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT definition [CAUTION: External Email] Hi Paul, meta: On 08/27/20 22:40, Paul wrote: > In Acpi10.h, EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT is defined as 0x10, but > should be 0x02 per the ACPI Specification. > > REF:https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2F > bugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2937&data=02%7C01%7Cp > aul.grimes%40amd.com%7C51cbad882a354dd9f33108d84f1e5a56%7C3dd8961fe488 > 4e608e11a82d994e183d%7C0%7C0%7C637346339077687090&sdata=WT8dJXxJhK > LhXU4qGObyYo3KN91WBs3%2FTesgkYdzssA%3D&reserved=0 > > Cc: Michael D Kinney <michael.d.kin...@intel.com> > Cc: Liming Gao <gaolim...@byosoft.com.cn> > Cc: Zhiguang Liu <zhiguang....@intel.com> > Signed-off-by: Paul G <paul.gri...@amd.com> > --- > MdePkg/Include/IndustryStandard/Acpi10.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) please consider setting the "user.name" git config knob to your full name. We now have: commit 5ffcbc46908a2037ae3260d3cfcc103e4a6a48c0 Author: Paul <paul.gri...@amd.com> Date: Fri Aug 28 04:40:51 2020 +0800 MdePkg: Correcting EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT definition and I like to be friendly :) but I think the Author field should state, in general, the full name, not just the first name. Similary, the Signed-off-by tag at the end of the commit message should carry the full name too. Please see section "Developer Certificate of Origin" in "ReadMe.rst": """ Signed-off-by: Developer Name develo...@example.org where ``Developer Name`` is the contributor's real name, and the email address is one the developer is reachable through at the time of contributing. """ It's quite obvious from the email address that "Paul G" stands for Paul Grimes, but still spell it out. (These requests are for the future, of course; the present patch has been merged.) Thanks! Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#64978): https://edk2.groups.io/g/devel/message/64978 Mute This Topic: https://groups.io/mt/76462757/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
