> -----Original Message----- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, September 04, 2020 5:44 PM > To: Chang, Abner (HPS SW/FW Technologist) <abner.ch...@hpe.com>; > devel@edk2.groups.io > Cc: Andrew Fish <af...@apple.com>; Leif Lindholm <l...@nuviainc.com>; > Michael D Kinney <michael.d.kin...@intel.com>; Leif Lindholm > <leif.lindh...@linaro.org> > Subject: Re: [PATCH v2 1/1] Maintainers.txt: Update reviewers of */RiscV64 > > Hi Abner, > > On 09/04/20 10:51, Chang, Abner (HPS SW/FW Technologist) wrote: > > > > > >> -----Original Message----- > >> From: Laszlo Ersek [mailto:ler...@redhat.com] > >> Sent: Friday, September 04, 2020 4:25 PM > >> To: Chang, Abner (HPS SW/FW Technologist) <abner.ch...@hpe.com>; > >> devel@edk2.groups.io > >> Cc: Andrew Fish <af...@apple.com>; Leif Lindholm <l...@nuviainc.com>; > >> Michael D Kinney <michael.d.kin...@intel.com>; Leif Lindholm > >> <leif.lindh...@linaro.org> > >> Subject: Re: [PATCH v2 1/1] Maintainers.txt: Update reviewers of > >> */RiscV64 > >> > >> On 09/04/20 09:19, Abner Chang wrote: > >>> Add reviewers for all /RiscV64 folders. > >>> > >>> Signed-off-by: Abner Chang <abner.ch...@hpe.com> > >>> Cc: Andrew Fish <af...@apple.com> > >>> Cc: Laszlo Ersek <ler...@redhat.com> > >>> Cc: Leif Lindholm <l...@nuviainc.com> > >>> Cc: Michael D Kinney <michael.d.kin...@intel.com> > >>> Cc: Leif Lindholm <leif.lindh...@linaro.org> > >>> Acked-by: Laszlo Ersek <ler...@redhat.com> > >>> --- > >>> Maintainers.txt | 5 +++++ > >>> 1 file changed, 5 insertions(+) > >>> > >>> diff --git a/Maintainers.txt b/Maintainers.txt index > >>> 57cd2fc662..6a22a14796 100644 > >>> --- a/Maintainers.txt > >>> +++ b/Maintainers.txt > >>> @@ -98,6 +98,11 @@ F: */Arm/ > >>> M: Leif Lindholm <l...@nuviainc.com> > >>> M: Ard Biesheuvel <ard.biesheu...@arm.com> > >>> > >>> +RISCV64 > >>> +F: */RiscV64/ > >>> +M: Abner Chang <abner.ch...@hpe.com> > >>> +R: Daniel Schaefer <daniel.schae...@hpe.com> > >>> + > >>> EDK II Continuous Integration: > >>> ------------------------------ > >>> .azurepipelines/ > >>> > >> > >> What are the changes relative to v1? > > R: for Abner changed to M: for Abner > >> > >> (Also, I believe Leif is away at the moment, and I think we should > >> have his ACK on this patch, before we merge the patch.) > > Yes, I had few conversations with Leif and Mike for this in this. > > Wait, that reminds me... OK, I've looked up the v1 discussion now. > > Is there any particular reason you didn't pick up Leif's Reviewed-by from the > v1 thread? Leif gave his R-b conditional on the R->M change for your name: Oops, I forget this. No particular reason to not picking up Leif's r-b. > > https://edk2.groups.io/g/devel/message/64807 > > and you have implemented that change. So I think Leif's R-b should have > been picked up. > > Based on <https://edk2.groups.io/g/devel/message/64810> -- do you have > push access to edk2 at this time? Because if that's the case, then we should > merge this patch now. > > Hmm let me see. > > https://github.com/orgs/tianocore/teams/edk-ii-maintainers/members > > Yes, you are a member of this group. > > https://github.com/orgs/tianocore/teams?query=@changab > > So I'm going to apply Leif's R-b from the v1 thread now, and then merge this > patch. Sure, thanks. Abner
> > Thanks, > Laszlo > > > Sure we can wait for his Ack. > > Thanks > >> > >> Thanks > >> Laszlo > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65051): https://edk2.groups.io/g/devel/message/65051 Mute This Topic: https://groups.io/mt/76625278/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
