On Monday, September 7, 2020 4:33 AM, Laszlo Ersek <ler...@redhat.com> wrote:
> Hi Scott, > > (+Rebecca) > > On 09/05/20 03:15, D Scott Phillips wrote: > > > From: D Scott Phillips d.scott.phill...@amperecomputing.com > > Leaving TlsChildHandle with the stale handle causes later use of https > > with the http instance to incorrectly skip tls reconfiguration, use > > the stale handle, and eventually call a garbage function pointer. > > > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1917 > > Signed-off-by: D Scott Phillips d.scott.phill...@amperecomputing.com > > > > ------------------------------------------------------------------------------------------------------------------------------ > > > > NetworkPkg/HttpDxe/HttpProto.c | 1 + > > 1 file changed, 1 insertion(+) > > diff --git a/NetworkPkg/HttpDxe/HttpProto.c b/NetworkPkg/HttpDxe/HttpProto.c > > index 3c7c6ff9f0..afc7db5a72 100644 > > --- a/NetworkPkg/HttpDxe/HttpProto.c > > +++ b/NetworkPkg/HttpDxe/HttpProto.c > > @@ -873,6 +873,7 @@ HttpCleanProtocol ( > > // Destroy the TLS instance. > > // > > HttpInstance->TlsSb->DestroyChild (HttpInstance->TlsSb, > > HttpInstance->TlsChildHandle); > > > > - HttpInstance->TlsChildHandle = NULL; > > } > > > > > > if (HttpInstance->Tcp4ChildHandle != NULL) { > > thanks a lot for tracking this down! > > I've reopened BZ#1917, and linked your patch email in a new comment. > > But, I'd also like to assign the BZ to you, if that's OK with you. Can > you please register in the TianoCore bugzilla instance for that? Certainly, account created and assignment taken. Thanks Laszlo. Scott -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65132): https://edk2.groups.io/g/devel/message/65132 Mute This Topic: https://groups.io/mt/76683729/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-